Remove unsupported top-level frontmatter fields - #53678
Conversation
PR TriageCategory: chore (WIP) | Risk: low | Priority: low (score 20)
Recommended action: defer — recheck once agent finishes and diff is populated
|
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ Ponytail Reviewer completed successfully! Lean already. Ship.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review. Completed PR review for #53678; no actionable review comments or blocking issues were found in the changed lines, so no GitHub write beyond completion signaling was needed.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #53678 does not have the implementation label and has only 21 new lines of code in business logic directories (threshold: 100).
|
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
There was a problem hiding this comment.
The change is clean and correct. Version and Include are removed from FrontmatterConfig (struct field, ToMap serialization), and a parallel table-driven test confirms both fields are now rejected by schema validation with a descriptive error message. Other uses of .Version/.Include in the codebase belong to unrelated types (engine configs, tool configs) — no orphaned references.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 21.4 AIC · ⌖ 8.77 AIC · ⊞ 5.7K
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design — clean dead-surface removal with appropriate regression coverage. Approving.
📋 Highlights
Positive Highlights
- ✅ Compiler-enforced cleanup: removing struct fields means any lingering references are caught at build time — no manual audit needed.
- ✅ Regression test is well-structured: table-driven over both fields, parallel subtests, checks both that an error is returned and that it mentions the rejected field name.
- ✅ PR description matches the implementation exactly.
No actionable issues found. The scope is tight, the test covers the intent, and the removal is justified by the absence of any compile-time or documented consumer.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 15.4 AIC · ⌖ 9.77 AIC · ⊞ 7.8K
Comment /matt to run again
There was a problem hiding this comment.
Pull request overview
Removes unsupported version and include fields from typed workflow frontmatter.
Changes:
- Removes both fields from
FrontmatterConfigand serialization. - Adds regression tests confirming schema rejection.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/frontmatter_types.go |
Removes unsupported typed fields. |
pkg/workflow/frontmatter_serialization.go |
Stops serializing removed fields. |
pkg/parser/schema_test.go |
Tests top-level field rejection. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
|
🎉 This pull request is included in a new release. Release: |
versionandincludeexisted inFrontmatterConfigdespite having no compile-time consumer, schema contract, documentation, or workflow usage. Their typed and serialized presence created unsupported frontmatter surface area.Remove dead configuration surface
VersionandIncludefromFrontmatterConfig.FrontmatterConfig.ToMap().Preserve schema contract
versionandincludeare rejected by the main workflow schema.