Skip to content

Remove unsupported top-level frontmatter fields - #53678

Merged
pelikhan merged 2 commits into
mainfrom
copilot/deep-report-resolve-frontmatter-fields
Aug 18, 2026
Merged

Remove unsupported top-level frontmatter fields#53678
pelikhan merged 2 commits into
mainfrom
copilot/deep-report-resolve-frontmatter-fields

Conversation

Copilot AI commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

version and include existed in FrontmatterConfig despite having no compile-time consumer, schema contract, documentation, or workflow usage. Their typed and serialized presence created unsupported frontmatter surface area.

  • Remove dead configuration surface

    • Drop top-level Version and Include from FrontmatterConfig.
    • Stop emitting either field from FrontmatterConfig.ToMap().
  • Preserve schema contract

    • Add regression coverage confirming top-level version and include are rejected by the main workflow schema.
on: workflow_dispatch
version: "1.0"   # rejected
include: shared  # rejected

@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

Category: chore (WIP) | Risk: low | Priority: low (score 20)

  • Draft, opened minutes ago with 0 diff — agent still generating changes (Add documentation and schema for top-level version and include field)
  • Batch: pr-batch:wip-drafts (6 similar just-opened WIP PRs)

Recommended action: defer — recheck once agent finishes and diff is populated

Generated by 🔧 PR Triage Agent · auto · 53.1 AIC · ⌖ 2.52 AIC · ⊞ 8.3K ·

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Add documentation and schema for top-level version and include fields Remove unsupported top-level frontmatter fields Aug 18, 2026
Copilot AI requested a review from pelikhan August 18, 2026 12:32
@pelikhan
pelikhan marked this pull request as ready for review August 18, 2026 12:33
Copilot AI balanced review requested due to automatic review settings August 18, 2026 12:33
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #53678

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

Completed PR review for #53678; no actionable review comments or blocking issues were found in the changed lines, so no GitHub write beyond completion signaling was needed.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #53678 does not have the implementation label and has only 21 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

Copy link
Copy Markdown
Contributor

Comment Memory

reviewed_at: 2026-08-18T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable issues found in changed lines
  - removal aligns typed frontmatter with schema contract
files_reviewed:
  - pkg/parser/schema_test.go
  - pkg/workflow/frontmatter_serialization.go
  - pkg/workflow/frontmatter_types.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 5.94 AIC · ⌖ 6.71 AIC · ⊞ 7K ·
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is clean and correct. Version and Include are removed from FrontmatterConfig (struct field, ToMap serialization), and a parallel table-driven test confirms both fields are now rejected by schema validation with a descriptive error message. Other uses of .Version/.Include in the codebase belong to unrelated types (engine configs, tool configs) — no orphaned references.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 21.4 AIC · ⌖ 8.77 AIC · ⊞ 5.7K

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /codebase-design — clean dead-surface removal with appropriate regression coverage. Approving.

📋 Highlights

Positive Highlights

  • ✅ Compiler-enforced cleanup: removing struct fields means any lingering references are caught at build time — no manual audit needed.
  • ✅ Regression test is well-structured: table-driven over both fields, parallel subtests, checks both that an error is returned and that it mentions the rejected field name.
  • ✅ PR description matches the implementation exactly.

No actionable issues found. The scope is tight, the test covers the intent, and the removal is justified by the absence of any compile-time or documented consumer.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 15.4 AIC · ⌖ 9.77 AIC · ⊞ 7.8K
Comment /matt to run again

@github-actions github-actions Bot mentioned this pull request Aug 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unsupported version and include fields from typed workflow frontmatter.

Changes:

  • Removes both fields from FrontmatterConfig and serialization.
  • Adds regression tests confirming schema rejection.
Show a summary per file
File Description
pkg/workflow/frontmatter_types.go Removes unsupported typed fields.
pkg/workflow/frontmatter_serialization.go Stops serializing removed fields.
pkg/parser/schema_test.go Tests top-level field rejection.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@pelikhan
pelikhan merged commit 7f8d2d8 into main Aug 18, 2026
90 of 102 checks passed
@pelikhan
pelikhan deleted the copilot/deep-report-resolve-frontmatter-fields branch August 18, 2026 12:50
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] Resolve top-level version and include frontmatter fields: undocumented, unschemaed, present in parser types

3 participants