Skip to content

Add shared AdaL agentic engine and smoke workflow - #53309

Closed
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/add-definitions-agentic-engine
Closed

Add shared AdaL agentic engine and smoke workflow#53309
pelikhan with Copilot wants to merge 1 commit into
mainfrom
copilot/add-definitions-agentic-engine

Conversation

Copilot AI commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Adds AdaL CLI as a reusable definition-based agentic engine with a private smoke workflow.

Changes

  • Shared engine

    • Pins @sylphai/adal-cli 1.7.0.
    • Uses ADAL_AUTH_TOKEN for headless authentication.
    • Adapts adal/model names and prompt delivery through a secure harness.
    • Normalizes AdaL NDJSON events for workflow telemetry.
    • Uses gh-aw CLI proxies because AdaL lacks documented headless MCP configuration.
  • Smoke coverage

    • Adds /smoke-adal for prompt, model, file-editing, shell, repository, and safe-output validation.
    • Registers AdaL in the shared engine catalog.
    • Includes generated workflow and command metadata.
engine:
  id: adal
model: adal/gpt-5.6-terra
imports:
  - shared/adal.md

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Triage

Category: feature (OpenTelemetry-related) | Risk: high | Score: 53/100

  • Impact: 28/50 (new engine integration, telemetry normalization)
  • Urgency: 15/30 (no CI signal yet)
  • Quality: 10/20 (large diff, no reviews yet)

Recommended action: fast_track

This PR touches OpenTelemetry/telemetry normalization — per triage policy it should be assigned to @mnkeifer and labeled otel (label applied; manual assignment needed since safe-outputs has no assign tool).

Generated by 🔧 PR Triage Agent · auto · 43 AIC · ⌖ 2.45 AIC · ⊞ 8.1K ·

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for adding the AdaL agentic engine integration! 🎉 This PR aligns well with the project's agentic-first development model and adds a clearly defined new capability.

What Looks Good

  • On-topic & focused — The PR adds a single cohesive feature: the shared AdaL engine with smoke workflow coverage.
  • Well-documented — The PR body clearly explains the changes, integration approach, and includes a usage example.
  • Core team workflow — Created through the Copilot SWE agent, following the project's agentic development process.

Suggestions for Strengthening This PR

Add unit test coverage — While the smoke workflow provides integration-level validation, consider adding traditional unit or integration tests for the AdaL harness logic, especially around:

  • NDJSON event normalization for telemetry
  • Model name adaptation and prompt delivery
  • Authentication flow with ADAL_AUTH_TOKEN

This would make the PR even more robust and easier for future maintainers to understand and modify the AdaL integration.

Consider adding edge-case validation — If the PR doesn't already cover error handling (e.g., missing auth token, malformed NDJSON), add tests for those scenarios.

If you'd like help adding these tests, you can assign this prompt to your coding agent:

Add unit tests for the AdaL agentic engine integration in the appropriate test directory.
Cover:
1. NDJSON event normalization — verify telemetry events are correctly transformed.
2. Model name adaptation — ensure model names are correctly mapped.
3. Prompt delivery through the secure harness.
4. Error handling: missing ADAL_AUTH_TOKEN, malformed input.

Make tests follow the project's existing test patterns and conventions.

Generated by ✅ Contribution Check · auto · 50 AIC · ⌖ 3.16 AIC · ⊞ 9.1K ·

@pelikhan
pelikhan marked this pull request as ready for review August 17, 2026 11:17
Copilot AI balanced review requested due to automatic review settings August 17, 2026 11:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds AdaL as a reusable agentic engine with a private smoke workflow.

Changes:

  • Defines AdaL authentication, execution, networking, and telemetry parsing.
  • Adds and compiles the /smoke-adal workflow.
  • Registers AdaL in engine and slash-command catalogs.
Show a summary per file
File Description
.github/workflows/shared/adal.md Defines the AdaL engine.
.github/workflows/smoke-adal.md Adds smoke-test coverage.
.github/workflows/smoke-adal.lock.yml Contains the compiled workflow.
.github/workflows/agentic_commands.yml Registers /smoke-adal.
.github/aw/engines.json Adds AdaL to the engine catalog.

Review details

  • Files reviewed: 4/5 changed files
  • Comments generated: 2
  • Review effort level: Balanced


## Test Requirements

1. **File Writing Testing**: Create a test file `/tmp/gh-aw/agent/smoke-test-adal-${{ github.run_id }}.txt` with content "Smoke test passed for AdaL" (create the directory if it doesn't exist)
Comment on lines +97 to +98
log-parser: |
function parseLog(logContent) {
@pelikhan pelikhan closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants