Enforce ctxbackground in cgo custom lint - #51936
Merged
Merged
Conversation
Closed
4 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the existing ctxbackground analyzer in CI for default and WebAssembly Go builds.
Changes:
- Adds
-ctxbackgroundto both custom-linter invocations. - Preserves production-only linting via
-test=false.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Enables ctxbackground in default and wasm lint checks. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Copilot
AI
changed the title
[WIP] Add ctxbackground analyzer to CI linter set
Enforce ctxbackground in cgo custom lint
Aug 11, 2026
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctxbackgroundis already type-resolved, documented, and clean for production code, but was not included in the CI-enforced custom linter set. This adds it to the cgo workflow socontext.Background()misuse is gated in both supported lint configurations.-ctxbackgroundto the defaultmake golint-customLINTER_FLAGS.-ctxbackgroundto the wasmGOOS=js GOARCH=wasm make golint-customLINTER_FLAGS.LINTER_FLAGS="... -contextcancelnotdeferred -ctxbackground -wgdonenotdeferred ..."