Skip ripgrep apt install when rg already exists by Copilot · Pull Request #51915 · github/gh-aw

Copilot · 2026-08-11T03:14:43Z

Copilot-generated jobs were doing package-manager work even on runners that already provide rg. This keeps minimal-runner compatibility while avoiding unnecessary apt updates and privileged installs on pre-baked images.

Copilot setup generation
- Add a conditional Install ripgrep step before Copilot CLI setup.
- Probe for rg first and only install ripgrep when missing.

if command -v rg >/dev/null 2>&1; then
  rg --version
else
  sudo apt-get update -qq
  sudo apt-get install -y -qq ripgrep
fi

Generated outputs
- Refresh Copilot workflow lock files and WASM golden fixtures to include the conditional setup step.
Release note
- Add a patch changeset for the generated Copilot job optimization.

Fixes Skip ripgrep apt install when rg is already available on custom runners #51723

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-08-11T03:35:42Z

        run: bash "${RUNNER_TEMP}/gh-aw/actions/install_awf_binary.sh" v0.27.44
+      - name: Install ripgrep
+        run: |
+          if command -v rg >/dev/null 2>&1; then


@copilot refactor into a shell script in actions/setup/sh + add tests

Addressed in ddbc80e: the generated step now calls actions/setup/sh/install_ripgrep.sh, with shell tests covering both the existing-rg and missing-rg paths wired into make test-scripts.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-08-11T03:54:13Z

✅ Test Quality Sentinel completed test quality analysis.

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-11T03:54:14Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories (53 additions detected).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-08-11T03:54:17Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-11T03:54:18Z

✅ Ponytail Reviewer completed successfully!

Reviewed PR #51915 for over-engineering (ponytail-review). No findings: the shell script extraction and test file follow existing repo conventions (per-script _test.sh files like install_awf_binary_test.sh), the Go change is a single small function with no speculative abstraction, and the change directly implements the reviewer's own prior request to refactor into a script + tests. Lean already. Ship.

Generated by Ponytail Reviewer for #51915

github-actions · 2026-08-11T03:54:28Z

✅ PR Code Quality Reviewer completed the code quality review.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

api.individual.githubcopilot.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.individual.githubcopilot.com"

See Network Configuration for more information.

🔎 Code quality review by PR Code Quality Reviewer

Copilot

Pull request overview

Adds conditional ripgrep provisioning to generated Copilot jobs, avoiding package-manager work when rg already exists.

Changes:

Adds and tests a shared ripgrep installer.
Emits the installer before Copilot CLI setup.
Refreshes generated workflows, golden fixtures, and release metadata.

Show a summary per file

File	Description
`actions/setup/sh/install_ripgrep.sh`	Adds conditional installation logic.
`actions/setup/sh/install_ripgrep_test.sh`	Tests present and missing `rg` paths.
`pkg/workflow/copilot_engine_installation.go`	Generates the ripgrep setup step.
`pkg/workflow/copilot_engine_test.go`	Updates installation-step assertions.
`Makefile`	Runs the new shell tests.
`.changeset/patch-copilot-ripgrep-install-probe.md`	Adds the patch release note.
`pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden`	Refreshes generated output.
`pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden`	Refreshes generated output.
`pkg/workflow/testdata/TestWasmGolden_CompileFixtures/playwright-cli-mode.golden`	Refreshes generated output.
`pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden`	Refreshes generated output.
`pkg/workflow/testdata/TestWasmGolden_AllEngines/copilot.golden`	Refreshes generated output.
`.github/workflows/*.lock.yml`	Refreshes affected compiled workflows with the setup step.

Review details

Tip

Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 203/203 changed files
Comments generated: 1
Review effort level: Balanced

+echo "ripgrep not found; installing with apt-get..."
+sudo apt-get update -qq
+sudo apt-get install -y -qq ripgrep


github-actions

The install_ripgrep.sh script correctly short-circuits with command -v rg before falling back to apt-get, and all lock files are consistently updated. No blocking issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 22.5 AIC · ⌖ 6.19 AIC · ⊞ 5.4K

github-actions · 2026-08-11T04:00:07Z

🧪 Test Quality Sentinel

PR: #51915 — Skip ripgrep apt install when rg already exists

Result: No Test Changes Detected

This PR contains 203 changed files (1065 additions, 18 deletions), primarily:

Generated lock files and WASM golden fixtures refreshed to include the conditional rg install step
A patch changeset entry
Source changes to the Copilot engine generator

The file pkg/workflow/copilot_engine_test.go appears in the changed files list, but no test functions were added or modified — the diff for that file is empty.

All pre-fetch signal files were empty:

go-new-test-funcs.txt — no new func Test* functions
go-modified-test-funcs.txt — no modified test functions
js-new-test-funcs.txt — no new JS test blocks
go-testmain-funcs.txt — no TestMain infrastructure changes
go-goleak-entries.txt — no goroutine-leak guard changes
missing-build-tags.txt — no violations

No violations detected.

i️ The production change (conditional rg probe before apt install) is not covered by a new test in this PR. This is acceptable for generated-output changes where the golden fixtures serve as regression tests.

Score: N/A — No test functions added or modified. Test Quality Sentinel skipped scoring.

🧪 Test quality analysis by Test Quality Sentinel · sonnet46 · 31.8 AIC · ⌖ 6.68 AIC · ⊞ 7.6K · ◷
_{Comment /review to run again}

github-actions

✅ Test Quality Sentinel: N/A — No test functions added or modified in this PR. No violations detected.

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs — the implementation is correct and well-tested. Approving.

Positive Highlights

✅ Probe-first pattern (command -v rg) correctly skips apt on pre-baked runners
✅ Shell script extracted from inline YAML — cleaner, reusable, and version-controlled
✅ Both paths covered by install_ripgrep_test.sh
✅ Go unit tests assert the ripgrep step is first and uses the script path
✅ Lock files properly recompiled

Minor Observation

install_ripgrep.sh falls back to apt-get (Linux-only). If macOS runner support is ever needed, a uname -s branch would be required — not blocking for current usage.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 75.9 AIC · ⌖ 6.45 AIC · ⊞ 7.1K
_{Comment /matt to run again}

github-actions · 2026-08-11T16:25:44Z

🎉 This pull request is included in a new release.

Release: v0.86.2

Initial plan

6e3467a

Copilot AI assigned Copilot and pelikhan Aug 11, 2026

Copilot AI linked an issue Aug 11, 2026 that may be closed by this pull request

Skip ripgrep apt install when rg is already available on custom runners #51723

Closed

Copilot started work on behalf of pelikhan August 11, 2026 03:14 View session

Skip ripgrep install when rg exists

07a30b7

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan reviewed Aug 11, 2026

View reviewed changes

Copilot AI changed the title ~~[WIP] Skip ripgrep apt install when rg is already available on custom runners~~ Skip ripgrep apt install when rg already exists Aug 11, 2026

Copilot finished work on behalf of pelikhan August 11, 2026 03:36

Copilot AI requested a review from pelikhan August 11, 2026 03:36

Copilot started work on behalf of pelikhan August 11, 2026 03:37 View session

Refactor ripgrep setup into script

ddbc80e

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan marked this pull request as ready for review August 11, 2026 03:53

Copilot AI balanced review requested due to automatic review settings August 11, 2026 03:53

Copilot started reviewing on behalf of pelikhan August 11, 2026 03:54 View session

Copilot finished work on behalf of pelikhan August 11, 2026 03:55

Copilot AI reviewed Aug 11, 2026

View reviewed changes

Comment thread actions/setup/sh/install_ripgrep.sh

Comment on lines +11 to +13

echo "ripgrep not found; installing with apt-get..."

sudo apt-get update -qq

sudo apt-get install -y -qq ripgrep

github-actions Bot approved these changes Aug 11, 2026

View reviewed changes

github-actions Bot mentioned this pull request Aug 11, 2026

[aw] PR Code Quality Reviewer produced no safe outputs #51898

Closed

github-actions Bot added the needs-review label Aug 11, 2026

github-actions Bot approved these changes Aug 11, 2026

View reviewed changes

github-actions Bot mentioned this pull request Aug 11, 2026

[aw] No-Op Runs #48838

Open

github-actions Bot approved these changes Aug 11, 2026

View reviewed changes

pelikhan merged commit ed2882d into main Aug 11, 2026
99 of 116 checks passed

pelikhan deleted the copilot/skip-ripgrep-install-when-available-again branch August 11, 2026 04:02

github-actions Bot mentioned this pull request Aug 11, 2026

Smoke Test: MAI-Code-1-Flash - 31491017664 #52028

Closed

Uh oh!

Conversation

Copilot AI commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 11, 2026

🧪 Test Quality Sentinel

Result: No Test Changes Detected

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Positive Highlights

Minor Observation

Uh oh!

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading

github-actions Bot commented Aug 11, 2026 •

edited

Loading