Skip to content

Fix smoke-trigger.yml startup_failure and missing secrets for workflow_call#18629

Merged
pelikhan merged 3 commits intomainfrom
copilot/debug-smoke-trigger-workflow
Feb 27, 2026
Merged

Fix smoke-trigger.yml startup_failure and missing secrets for workflow_call#18629
pelikhan merged 3 commits intomainfrom
copilot/debug-smoke-trigger-workflow

Conversation

Copy link
Contributor

Copilot AI commented Feb 27, 2026

smoke-trigger.yml was failing with startup_failure before any jobs ran because the caller job granted fewer permissions than the callee's jobs required, and secrets were not being passed through to the called workflow.

Error 1 — Startup failure (permissions):

Error calling workflow 'smoke-workflow-call.lock.yml':
  The nested job 'conclusion' is requesting 'discussions: write, issues: write',
  but is only allowed 'discussions: none, issues: none'.
  The nested job 'safe_outputs' is requesting 'discussions: write, issues: write',
  but is only allowed 'discussions: none, issues: none'.

Error 2 — Missing secrets:

Error: None of the following secrets are set: COPILOT_GITHUB_TOKEN

Secrets are not automatically inherited in workflow_call contexts without secrets: inherit.

Fixes in smoke-trigger.yml:

uses: ./.github/workflows/smoke-workflow-call.lock.yml
secrets: inherit        # added — passes secrets to called workflow
permissions:
  contents: read
  discussions: write    # added
  issues: write         # added
  pull-requests: write

Warning

Custom agent used: ci-cleaner
Tidies up the repository CI state by formatting sources, running linters, fixing issues, running tests, and recompiling workflows

Original prompt

Debug https://github.com/github/gh-aw/actions/workflows/smoke-trigger.yml

Custom agent used: ci-cleaner
Tidies up the repository CI state by formatting sources, running linters, fixing issues, running tests, and recompiling workflows


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug smoke trigger workflow Fix smoke-trigger.yml startup_failure due to insufficient permissions for workflow_call Feb 27, 2026
@pelikhan pelikhan marked this pull request as ready for review February 27, 2026 05:31
Copilot AI review requested due to automatic review settings February 27, 2026 05:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a GitHub Actions startup_failure in smoke-trigger.yml by ensuring the caller workflow grants sufficient GITHUB_TOKEN permissions to match the requirements of the reusable workflow invoked via workflow_call.

Changes:

  • Added discussions: write and issues: write to the caller job permissions in .github/workflows/smoke-trigger.yml to satisfy the callee jobs’ required permissions.
  • Prevents parse-time validation failure when invoking ./.github/workflows/smoke-workflow-call.lock.yml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pelikhan
Copy link
Contributor

…orkflow

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 27, 2026

@copilot check this failure https://github.com/github/gh-aw/actions/runs/22474121639

The permissions fix resolved the startup_failure, but the workflow then failed at the activation job because COPILOT_GITHUB_TOKEN was empty — secrets are not automatically inherited when using workflow_call.

Fixed in c111c0c by adding secrets: inherit to the caller job in smoke-trigger.yml. This ensures all secrets (including COPILOT_GITHUB_TOKEN) are passed through to the called workflow.

Copilot AI changed the title Fix smoke-trigger.yml startup_failure due to insufficient permissions for workflow_call Fix smoke-trigger.yml startup_failure and missing secrets for workflow_call Feb 27, 2026
@pelikhan pelikhan merged commit f19b6f9 into main Feb 27, 2026
59 checks passed
@pelikhan pelikhan deleted the copilot/debug-smoke-trigger-workflow branch February 27, 2026 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants