Trim wasm golden test suite to 3 essential fixtures#17142
Merged
Conversation
Closed
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Analyzed 21 fixture files and retained only the 3 most essential: - basic-copilot: minimal baseline sanity check - smoke-copilot: comprehensive real-world test (imports, tools, network, MCP) - with-imports: tests virtual-filesystem import resolution (WASM-specific) Deleted 18 fixture .md files and 18 corresponding .golden files. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyze WASM golden test suite and retain essential files
Trim wasm golden test suite to 3 essential fixtures
Feb 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces the WASM golden test suite footprint by removing redundant fixtures/golden outputs, keeping only three fixtures intended to provide broad coverage with lower maintenance cost.
Changes:
- Deleted 18 markdown fixtures and their corresponding
TestWasmGolden_CompileFixtures/*.goldenoutputs. - Retained only
basic-copilot,smoke-copilot, andwith-importsfixtures (and goldens) in the WASM golden suite. - Updated the agent dispatcher documentation for Dependabot guidance (minor formatting issue noted in review comment).
Reviewed changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/testdata/wasm_golden/fixtures/with-tools.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/with-safe-outputs.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/with-permissions.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/with-expressions.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/strict-mode.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/smoke-test-tools.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/smoke-codex.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/smoke-claude.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/schedule-trigger.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/push-with-head-commit.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/push-trigger.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/pr-trigger.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/issue-trigger.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/dispatch-with-inputs.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/codex-with-tools.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/claude-with-network.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/basic-codex.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/fixtures/basic-claude.md | Removed redundant WASM golden fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-tools.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-safe-outputs.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-permissions.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/strict-mode.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/schedule-trigger.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/push-with-head-commit.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/push-trigger.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/dispatch-with-inputs.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/codex-with-tools.golden | Removed golden output corresponding to deleted fixture. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-codex.golden | Removed golden output corresponding to deleted fixture. |
| .github/agents/agentic-workflows.agent.md | Updated Dependabot guidance reference (Markdown formatting issue needs a small fix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Fix Dependabot PRs | ||
| **Load when**: User needs to close or fix open Dependabot PRs that update dependencies in generated manifest files (`.github/workflows/package.json`, `.github/workflows/requirements.txt`, `.github/workflows/go.mod`) or `.github/aw/actions-lock.json` | ||
| **Load when**: User needs to close or fix open Dependabot PRs that update dependencies in generated manifest files (`.github/workflows/package.json`, `.github/workflows/requirements.txt`, `.github/workflows/go.mod`) or `https://github.com/github/gh-aw/blob/main/.github/aw/actions-lock.json` |
There was a problem hiding this comment.
The inline code span for the actions-lock.json URL is missing a closing backtick, so the rest of the paragraph may render as code in Markdown. Close the backtick after actions-lock.json (or convert this to a normal Markdown link) to fix formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wasm golden test suite had 21 fixtures covering redundant scenarios, creating unnecessary maintenance overhead when the compiler output changes.
Changes
Deleted 18 fixture/golden pairs — removed
basic-claude,basic-codex,claude-with-network,codex-with-tools,dispatch-with-inputs,issue-trigger,pr-trigger,push-trigger,push-with-head-commit,schedule-trigger,smoke-claude,smoke-codex,smoke-test-tools,strict-mode,with-expressions,with-permissions,with-safe-outputs,with-toolsRetained 3 fixtures that provide maximal coverage with minimal overlap:
basic-copilot— minimal baseline; catches core compilation regressionssmoke-copilot— comprehensive real-world fixture covering imports, tools, network, MCP, safe-outputs, and multiple trigger typeswith-imports— exercises the WASM virtual filesystem import resolution path specifically tested byTestWasmGolden_CompileWithImportsNo changes to test code —
TestWasmGolden_CompileFixturesandTestWasmGolden_NativeVsStringAPIdynamically scan the fixtures directory.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw GO111MODULE 64/bin/go git conf�� user.email test@example.com /usr/bin/git -json GO111MODULE 64/bin/go git(http block)https://api.github.com/repos/actions/ai-inference/git/ref/tags/v1/usr/bin/gh gh api /repos/actions/ai-inference/git/ref/tags/v1 --jq .object.sha -json GO111MODULE 0/x64/bin/node GOINSECURE GOMOD GOMODCACHE go t-ha�� ithub/workflows/agent-persona-explorer.md GO111MODULE 0/x64/bin/node GOINSECURE GOMOD GOMODCACHE 0/x64/bin/node(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v3/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v3 --jq .object.sha g_.a GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env 01/main.md GO111MODULE ache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE ortcfg(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha vaScript2631073613/001/test-complex-frontmatter-with-tools.md GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env 3758-27484/test-532178377 GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env runs/20260220-123758-27484/test-3906721857/.github/workflows GO111MODULE .cfg l GOMOD GOMODCACHE go(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v4 --jq .object.sha --show-toplevel go /usr/bin/git wgLN/Txed9nl5PDegit GO111MODULE 64/bin/go git conf�� user.email test@example.com /usr/bin/git che/go-build/df/git **/*.cjs 64/bin/go git(http block)https://api.github.com/repos/actions/checkout/git/ref/tags/v5/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/pkg/tool/linux_amd64/link GOINSECURE GOMOD GOMODCACHE 64/pkg/tool/linuf() { test "$1" = get && echo "******"; }; f get(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha r-test1245696372/test1.md r-test1245696372/test2.lock.yml /tmp/go-build2513963967/b402/mathutil.test GOSUMDB GOWORK 64/bin/go /tmp/go-build2513963967/b402/mathutil.test -tes�� runs/20260220-123758-27484/test-532178377 -test.v=true /usr/bin/git -test.timeout=10git -test.run=^Test -test.short=true--show-toplevel git(http block)/usr/bin/gh gh api /repos/actions/checkout/git/ref/tags/v5 --jq .object.sha -unreachable=false /tmp/go-build2513963967/b108/vet.cfg /usr/bin/git 626320/b384/embegit GOPROXY 64/bin/go git rev-�� --show-toplevel /opt/hostedtoolcache/go/1.25.0/xGO111MODULE /opt/hostedtoolcache/node/24.13.0/x64/bin/node /tmp/go-build775git -trimpath 64/bin/go /opt/hostedtoolcache/node/24.13.0/x64/bin/node(http block)https://api.github.com/repos/actions/github-script/git/ref/tags/v8/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha GOSUMDB GOWORK 64/bin/go GOINSECURE GOMOD GOMODCACHE go env ck 'scripts/**/*GOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD erignore go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh api /repos/actions/github-script/git/ref/tags/v8 --jq .object.sha ck 'scripts/**/*GOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/actions/setup-go/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/setup-go/git/ref/tags/v4 --jq .object.sha bot-detection.md GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env runs/20260220-123758-27484/test-2586139036/.github/workflows GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/actions/setup-node/git/ref/tags/v4/usr/bin/gh gh api /repos/actions/setup-node/git/ref/tags/v4 --jq .object.sha blog-auditor.md GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE /opt/hostedtoolcache/go/1.25.0/x64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/github/gh-aw/actions/runs/1/artifacts/usr/bin/gh gh run download 1 --dir test-logs/run-1 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/github/gh-aw/actions/runs/12345/artifacts/usr/bin/gh gh run download 12345 --dir test-logs/run-12345 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/github/gh-aw/actions/runs/12346/artifacts/usr/bin/gh gh run download 12346 --dir test-logs/run-12346 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/github/gh-aw/actions/runs/2/artifacts/usr/bin/gh gh run download 2 --dir test-logs/run-2 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/github/gh-aw/actions/runs/3/artifacts/usr/bin/gh gh run download 3 --dir test-logs/run-3 GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go estl�� -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/github/gh-aw/actions/runs/4/artifacts/usr/bin/gh gh run download 4 --dir test-logs/run-4 GO111MODULE x_amd64/compile GOINSECURE GOMOD GOMODCACHE x_amd64/compile env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/github/gh-aw/actions/runs/5/artifacts/usr/bin/gh gh run download 5 --dir test-logs/run-5 GO111MODULE x_amd64/link GOINSECURE GOMOD GOMODCACHE x_amd64/link env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE cx/AERBTSiwFBTdGDiIa9qx/H4W_iTHyWdoVr4iAs4gc(http block)https://api.github.com/repos/github/gh-aw/actions/workflows/usr/bin/gh gh workflow list --json name,state,path heck '**/*.cjs' GOINSECURE GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env tformat GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 100 GOMOD GOMODCACHE go env q3ur/qEc8rgWjWkCGOSUMDB GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE 626320/b356/importcfg(http block)/usr/bin/gh gh run list --json databaseId,number,url,status,conclusion,workflowName,createdAt,startedAt,updatedAt,event,headBranch,headSha,displayTitle --workflow nonexistent-workflow-12345 --limit 6 GOMOD GOMODCACHE x_amd64/vet env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/github/gh-aw/git/ref/tags/v1.0.0/usr/bin/gh gh api /repos/github/gh-aw/git/ref/tags/v1.0.0 --jq .object.sha ty-test.md GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env 912068394/.github/workflows GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/nonexistent/action/git/ref/tags/v999.999.999/usr/bin/gh gh api /repos/nonexistent/action/git/ref/tags/v999.999.999 --jq .object.sha -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go env 2252490923/.github/workflows GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/nonexistent/repo/actions/runs/12345/usr/bin/gh gh run view 12345 --repo nonexistent/repo --json status,conclusion GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/owner/repo/actions/workflows/usr/bin/gh gh workflow list --json name,state,path --repo owner/repo 64/bin/go GOINSECURE GOMOD GOMODCACHE ache/go/1.25.0/xGO111MODULE env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/owner/repo/contents/file.md/tmp/go-build2513963967/b380/cli.test /tmp/go-build2513963967/b380/cli.test -test.testlogfile=/tmp/go-build2513963967/b380/testlog.txt -test.paniconexit0 -test.v=true -test.parallel=4 -test.timeout=10m0s -test.run=^Test -test.short=true GOINSECURE GOMOD GOMODCACHE go ache�� -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)https://api.github.com/repos/test-owner/test-repo/actions/secrets/usr/bin/gh gh api /repos/test-owner/test-repo/actions/secrets --jq .secrets[].name GOSUMDB GOWORK 64/bin/go GOINSECURE GOMOD GOMODCACHE go env -json GO111MODULE 64/bin/go GOINSECURE GOMOD GOMODCACHE go(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.