Skip to content

chore: rm redundant header from report#15168

Merged
mnkiefer merged 1 commit intomainfrom
bot-det-body
Feb 12, 2026
Merged

chore: rm redundant header from report#15168
mnkiefer merged 1 commit intomainfrom
bot-det-body

Conversation

@mnkiefer
Copy link
Contributor

  • Header is already in issue title, so not needed in issue body.

@mnkiefer mnkiefer self-assigned this Feb 12, 2026
Copilot AI review requested due to automatic review settings February 12, 2026 13:28
@mnkiefer mnkiefer merged commit 620c990 into main Feb 12, 2026
35 checks passed
@mnkiefer mnkiefer deleted the bot-det-body branch February 12, 2026 13:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a redundant top-level Markdown header from the bot-detection workflow’s generated GitHub issue body (the issue title already provides the header), aiming to align the report body formatting with repo guidance.

Changes:

  • Dropped the # ... header line from the generated issue body in the bot-detection workflow.
Comments suppressed due to low confidence (1)

.github/workflows/bot-detection.yml:156

  • The generated issue body still uses h2 headers (e.g. ## @${login}), which conflicts with the repo’s report formatting guidelines (use ### or lower; never #/##). Consider downgrading account headings to ### and adjusting the nested section headers accordingly to preserve hierarchy.
            body = `Recently-created accounts often indicate bots, spam accounts, or coordinated attacks.\n\n`;

            const sorted = Array.from(highRiskAccounts.entries()).sort((a, b) => a[1].daysOld - b[1].daysOld);

            for (const [login, data] of sorted) {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

const today = new Date().toISOString().split('T')[0];
let body = `# 🚨 HIGH RISK: Brand New Accounts Detected — ${today}\n\n`;
body += `Recently-created accounts often indicate bots, spam accounts, or coordinated attacks.\n\n`;
body = `Recently-created accounts often indicate bots, spam accounts, or coordinated attacks.\n\n`;
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

body is assigned without being declared (body = ...). This creates an implicit global in non-strict mode and will throw in strict mode. Declare it here (e.g., let body = ...) to keep the script scope-safe and reliable.

Suggested change
body = `Recently-created accounts often indicate bots, spam accounts, or coordinated attacks.\n\n`;
let body = `Recently-created accounts often indicate bots, spam accounts, or coordinated attacks.\n\n`;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants