Fix gosec G104 violations in MCP config renderers #13677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security linter failing on unhandled error returns from
RenderJSONMCPConfig()in MCP configuration renderers.Changes
_ =in 4 MCP renderer callsites:pkg/workflow/copilot_mcp.gopkg/workflow/claude_mcp.gopkg/workflow/custom_engine.gopkg/workflow/codex_mcp.goContext
RenderJSONMCPConfig()returnserrorbut the current implementations always returnnil. The calling functions don't propagate errors, so the return value is intentionally discarded to satisfy the linter.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.