-
Notifications
You must be signed in to change notification settings - Fork 46
Fix changesets workflow - Remove duplicate tag creation and update job dependencies #13592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix changesets workflow - Remove duplicate tag creation and update job dependencies #13592
Conversation
The changeset.js script was trying to create a git tag that already exists, causing the GitHub Actions workflow to fail. The workflow's release job creates the tag first, then the changesets job calls changeset.js which tried to create the same tag again. Changes: - Removed tag creation (git tag -a) from changeset.js - Removed tag push (git push origin <tag>) from changeset.js - Updated error recovery instructions to not mention tag operations - Added documentation clarifying the script expects tags to be pre-created The script now only updates CHANGELOG.md, deletes changeset files, commits changes, and pushes to main - no tag operations. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
Copilot, update the |
|
@copilot, update the needs for the changelog job so it runs after the agent job and depends on the agent job. |
…-64ca-46cd-b3a2-f727bb8800c5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a workflow failure by removing duplicate git tag creation from the changeset.js script. The release workflow was failing because the changesets job attempted to create a git tag that the release job had already created, resulting in a "fatal: tag already exists" error.
Changes:
- Removed git tag creation and push operations from
changeset.js - Updated documentation to clarify that tags must be pre-created by the caller
- Updated error recovery instructions to reflect the removal of tag operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The changesets job now runs after the agent job completes, ensuring release highlights are generated before the CHANGELOG is updated. Before: agent -> depends on changesets After: changesets -> depends on agent This allows the agent to generate release highlights first, then the CHANGELOG can be updated with the full context. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Updated in cc494d8. The changesets job now depends on the agent job and runs after it completes. |
The
changesetsworkflow job was failing becausechangeset.jsattempted to create a git tag that thereleasejob had already created, resulting infatal: tag already exists.Workflow sequence
The release workflow now runs jobs in the following order:
changeset.js→ updates CHANGELOG → commitsChanges
Script Changes
git tag -acommand from changeset.jsgit push origin <tag>command from changeset.jsThe script now only updates CHANGELOG.md, deletes changeset files, commits changes, and pushes to main—no tag operations.
Workflow Changes
changesetsjob dependencies to includeagentjobchangesetsjob now runs after theagentjob completes, ensuring release highlights are generated before the CHANGELOG is updatedOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.