Skip to content

Fix flaky dispatch_workflow test timing assertion #13457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Feb 3, 2026
+3 −2
Merged

Fix flaky dispatch_workflow test timing assertion #13457

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f5a3b0
Initial plan
Copilot Feb 3, 2026
2ab366e
fix: adjust dispatch_workflow test timing threshold to account for ji…
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions actions/setup/js/dispatch_workflow.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,9 @@ describe("dispatch_workflow handler factory", () => {
// Verify first dispatch had no delay
expect(firstDispatchTime - startTime).toBeLessThan(1000);

// Verify second dispatch was delayed by at least 5 seconds
expect(secondDispatchTime - firstDispatchTime).toBeGreaterThanOrEqual(5000);
// Verify second dispatch was delayed by approximately 5 seconds
// Use a slightly lower threshold (4995ms) to account for timing jitter
expect(secondDispatchTime - firstDispatchTime).toBeGreaterThanOrEqual(4995);
expect(secondDispatchTime - firstDispatchTime).toBeLessThan(6000);
});
});
Loading