Migrate references from githubnext to github #13358
Conversation
There was a problem hiding this comment.
Pull request overview
Updates hardcoded repository/image/documentation references from githubnext to github to reflect the new canonical org in links, container images, and some API calls.
Changes:
- Updated GitHub URLs in error messages, docs/comments, and test fixtures from
githubnext/*togithub/*. - Switched default container image constants to
ghcr.io/github/*for MCP Gateway and Serena. - Updated the update-check release lookup endpoint to query
github/gh-aw.
Reviewed changes
Copilot reviewed 180 out of 180 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/step_order_validation.go | Updates bug-report issue URLs to github/gh-aw. |
| pkg/workflow/safe_outputs_tools_schema_test.go | Updates regression-test run links to github/gh-aw. |
| pkg/workflow/safe_outputs_integration_test.go | Updates issue tracker link to github/gh-aw. |
| pkg/workflow/mcp_setup_generator_test.go | Updates MCP gateway container image references to ghcr.io/github/gh-aw-mcpg. |
| pkg/workflow/mcp_gateway_entrypoint_mounts_e2e_test.go | Updates MCP gateway container image references to ghcr.io/github/gh-aw-mcpg. |
| pkg/workflow/header.go | Updates “more information” doc link to github/gh-aw. |
| pkg/workflow/docker_predownload_test.go | Updates expected predownload image to ghcr.io/github/gh-aw-mcpg. |
| pkg/workflow/dependabot_test.go | Updates expected generated module path to github.com/github/gh-aw-workflows-deps. |
| pkg/workflow/dependabot.go | Updates generated go.mod module path to github.com/github/gh-aw-workflows-deps. |
| pkg/workflow/compiler_validation_test.go | Updates expected header link to github/gh-aw. |
| pkg/workflow/codex_engine.go | Updates issue link comment to github/gh-aw. |
| pkg/workflow/claude_tools.go | Updates issue link comment to github/gh-aw. |
| pkg/repoutil/repoutil_test.go | Updates test URL fixtures to github/gh-aw. |
| pkg/parser/github_urls_test.go | Updates URL parsing fixtures to github/gh-aw and github/gh-aw-trial. |
| pkg/constants/constants.go | Updates default container image constants to ghcr.io/github/*. |
| pkg/console/spinner_test.go | Updates issue link comment to github/gh-aw. |
| pkg/cli/update_check.go | Updates GitHub API endpoint to query releases from github/gh-aw. |
| pkg/cli/trial_issue_mode_test.go | Updates trial issue URL fixture to github/gh-aw-trial. |
| pkg/cli/spec_test.go | Updates workflow spec URL fixture to github/gh-aw-trial. |
| pkg/cli/spec_github_url_test.go | Updates spec URL fixtures to github/gh-aw*. |
| pkg/cli/spec.go | Updates error message example URL to github/gh-aw. |
| pkg/cli/repo_error_messages_test.go | Updates error message example URL to github/gh-aw. |
| pkg/cli/mcp_inspect_mcp.go | Updates tools docs link to github/gh-aw. |
| pkg/cli/logs_mcp_failure_test.go | Updates referenced Actions run link to github/gh-aw. |
| pkg/cli/init_mcp_test.go | Updates install-script URL to raw.githubusercontent.com/github/gh-aw/.... |
| pkg/cli/git_helpers_test.go | Updates GitHub URL fixtures to github/gh-aw. |
| pkg/cli/firewall_log_integration_test.go | Updates sample API URL in log fixture to api.github.com/repos/github/gh-aw. |
| pkg/cli/docker_build_integration_test.go | Updates tested Docker image reference to ghcr.io/github/gh-aw:latest. |
| pkg/cli/devcontainer.go | Updates devcontainer postCreate install-script URL to github/gh-aw. |
| pkg/cli/copilot_setup_test.go | Updates install-script URL fixtures to github/gh-aw. |
| pkg/cli/copilot_setup.go | Updates install-script URL in generated/copied YAML to github/gh-aw. |
Comments suppressed due to low confidence (6)
pkg/parser/github_urls_test.go:233
- The raw.githubusercontent.com URL now uses the "github" owner, but wantOwner is still "githubnext". Update wantOwner to "github" (and keep repo/ref/path expectations the same).
pkg/parser/github_urls_test.go:243 - The raw.githubusercontent.com URL now uses the "github" owner, but wantOwner is still "githubnext". Update wantOwner to "github" to match the URL.
pkg/parser/github_urls_test.go:477 - The run/job URL input was updated to "github/gh-aw", but wantOwner remains "githubnext". Update wantOwner to "github" so the parsed components match the input URL.
pkg/cli/git_helpers_test.go:24 - This test now uses "https://github.com/github/gh-aw" but still expects the parsed slug to be "githubnext/gh-aw". Update the expected value to "github/gh-aw" to match the URL.
pkg/cli/spec_github_url_test.go:76 - This raw.githubusercontent.com test URL now uses the "github" owner, but wantRepo is still "githubnext/gh-aw". Update wantRepo to "github/gh-aw" to match the URL.
pkg/cli/spec_github_url_test.go:85 - This raw.githubusercontent.com test URL now uses the "github" owner, but wantRepo is still "githubnext/gh-aw". Update wantRepo to "github/gh-aw" so the parsed repo slug matches the input URL.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: "HTTPS format with .git", | ||
| url: "https://github.com/githubnext/gh-aw.git", | ||
| url: "https://github.com/github/gh-aw.git", | ||
| expectedOwner: "githubnext", | ||
| expectedRepo: "gh-aw", | ||
| expectError: false, |
There was a problem hiding this comment.
The HTTPS test case URL was updated to "https://github.com/github/gh-aw.git", but the expected owner is still "githubnext". Since ParseGitHubURL returns the owner from the URL path, this will fail; update expectedOwner to "github" (and keep repo as "gh-aw").
| name: "Blob URL with main branch", | ||
| url: "https://github.com/githubnext/gh-aw-trial/blob/main/workflows/release-issue-linker.md", | ||
| url: "https://github.com/github/gh-aw-trial/blob/main/workflows/release-issue-linker.md", | ||
| wantType: URLTypeBlob, | ||
| wantOwner: "githubnext", | ||
| wantRepo: "gh-aw-trial", |
There was a problem hiding this comment.
The URL was changed to the "github" owner, but wantOwner is still set to "githubnext". Since ParseGitHubURL derives the owner from the URL, update wantOwner to "github".
This issue also appears in the following locations of the same file:
- line 229
- line 239
- line 473
| name: "GitHub URL - blob with main branch", | ||
| spec: "https://github.com/githubnext/gh-aw-trial/blob/main/workflows/release-issue-linker.md", | ||
| spec: "https://github.com/github/gh-aw-trial/blob/main/workflows/release-issue-linker.md", | ||
| wantRepo: "githubnext/gh-aw-trial", | ||
| wantWorkflowPath: "workflows/release-issue-linker.md", | ||
| wantWorkflowName: "release-issue-linker", |
There was a problem hiding this comment.
The spec URL now points at "https://github.com/github/gh-aw-trial/...", but the expected repo slug is still "githubnext/gh-aw-trial". Update wantRepo to "github/gh-aw-trial" so parseWorkflowSpec expectations match the input URL.
| var release Release | ||
| err = client.Get("repos/githubnext/gh-aw/releases/latest", &release) | ||
| err = client.Get("repos/github/gh-aw/releases/latest", &release) | ||
| if err != nil { |
There was a problem hiding this comment.
getLatestRelease() now queries releases from "repos/github/gh-aw", but the user-facing upgrade hint still says "gh extension upgrade githubnext/gh-aw" (see checkForUpdates). Update the hint to "gh extension upgrade github/gh-aw" for consistency.
| // DefaultSerenaMCPServerContainer is the default container image for the Serena MCP server | ||
| const DefaultSerenaMCPServerContainer = "ghcr.io/githubnext/serena-mcp-server" | ||
| const DefaultSerenaMCPServerContainer = "ghcr.io/github/serena-mcp-server" |
There was a problem hiding this comment.
DefaultSerenaMCPServerContainer was updated to "ghcr.io/github/serena-mcp-server", but there are still tests asserting the old image string (e.g. pkg/workflow/importable_tools_test.go:159 expects "ghcr.io/githubnext/serena-mcp-server:latest"). Update those references (or keep the constant unchanged) to avoid failing tests and inconsistent defaults.
| name: "HTTPS URL with .git", | ||
| url: "https://github.com/githubnext/gh-aw.git", | ||
| url: "https://github.com/github/gh-aw.git", | ||
| expected: "githubnext/gh-aw", | ||
| }, |
There was a problem hiding this comment.
This test now uses "https://github.com/github/gh-aw.git" but still expects the parsed slug to be "githubnext/gh-aw". Update the expected value to "github/gh-aw" to match the URL.
| name: "blob URL with main branch", | ||
| url: "https://github.com/githubnext/gh-aw-trial/blob/main/workflows/release-issue-linker.md", | ||
| url: "https://github.com/github/gh-aw-trial/blob/main/workflows/release-issue-linker.md", | ||
| wantRepo: "githubnext/gh-aw-trial", | ||
| wantWorkflowPath: "workflows/release-issue-linker.md", | ||
| wantWorkflowName: "release-issue-linker", |
There was a problem hiding this comment.
This test case URL now uses the "github" owner, but wantRepo is still "githubnext/gh-aw-trial". Update wantRepo to "github/gh-aw-trial" to match the URL being parsed.
This issue also appears in the following locations of the same file:
- line 73
- line 82
| steps: | ||
| - name: Install gh-aw extension | ||
| run: | | ||
| curl -fsSL https://raw.githubusercontent.com/githubnext/gh-aw/refs/heads/main/install-gh-aw.sh | bash | ||
| curl -fsSL https://raw.githubusercontent.com/github/gh-aw/refs/heads/main/install-gh-aw.sh | bash | ||
| ` |
There was a problem hiding this comment.
In this file, dev/script mode now installs from raw.githubusercontent.com/github/gh-aw, but release mode still references the setup action as "githubnext/gh-aw/actions/setup-cli". If the goal is to migrate org ownership, this leaves behavior inconsistent across modes (and likely points at the wrong action repo). Consider updating the release-mode action reference to "github/gh-aw/actions/setup-cli" as well (and adjust related tests).
| // after Start (before the goroutine initializes) does not cause a deadlock. | ||
| // This reproduces the issue from https://github.com/githubnext/gh-aw/issues/XXX | ||
| // This reproduces the issue from https://github.com/github/gh-aw/issues/XXX | ||
| func TestSpinnerStopBeforeStartRaceCondition(t *testing.T) { |
There was a problem hiding this comment.
The test comment links to "https://github.com/github/gh-aw/issues/XXX" which is not a valid issue URL. Replace XXX with the real issue number (or remove the link) so the reference is actionable.
Update various references in the codebase to replace "githubnext" with "github" for consistency and accuracy. This change enhances clarity in repository URLs and related documentation.