-
Notifications
You must be signed in to change notification settings - Fork 46
Align Go frontmatter hash with JavaScript text-based implementation #13094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
|
@copilot revert Serena tool changes, merge main and recompile |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Go front matter hash consistency algorithm
Align Go frontmatter hash with JavaScript text-based implementation
Feb 1, 2026
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
pelikhan
approved these changes
Feb 1, 2026
Contributor
|
@copilot merge main and recompile |
This was referenced Feb 1, 2026
…h-consistency # Conflicts: # .github/workflows/smoke-copilot.lock.yml # .github/workflows/smoke-project.lock.yml
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Go frontmatter hash to match JavaScript text-based implementation
Problem: Go uses YAML-parsed structured data for hashing, JavaScript uses text-based approach (no YAML parsing). They produce different hashes.
Solution: Update Go implementation to match JavaScript's text-based approach.
Summary
Successfully updated the Go frontmatter hash implementation to use a text-based approach matching the JavaScript implementation. All tests now pass with cross-language consistency.
Changes Made
Go Implementation (
pkg/parser/frontmatter_hash.go):JavaScript Version Update (
actions/setup/js/frontmatter_hash_pure.cjs):Test Updates:
Workflow Recompilation:
Completed
All tasks completed successfully!
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.