Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 1, 2026

Problem

Individual job builders for update-project and create-project-status-update existed but were never called in production. These safe outputs are processed by the unified project handler manager (buildProjectHandlerManagerStep) since the handler architecture consolidation.

Changes

Removed dead code:

  • pkg/workflow/update_project_job.go - Legacy buildUpdateProjectJob function (92 lines)
  • pkg/workflow/update_project_test.go - Tests for removed builder (328 lines)
  • pkg/workflow/update_project_token_test.go - Token tests (121 lines)
  • pkg/workflow/safe_outputs_integration_test.go - Removed update_project test case

Retained:

  • parseUpdateProjectConfig() in update_project.go - Still used by unified handler
  • parseCreateProjectStatusUpdateConfig() in create_project_status_update.go - Still used by unified handler

Context

The unified project handler manager in compiler_safe_outputs_steps.go handles all project-related safe outputs:

// buildProjectHandlerManagerStep builds a single step that uses the safe output project handler manager
// to dispatch project-related messages (create_project, update_project, copy_project, create_project_status_update)
func (c *Compiler) buildProjectHandlerManagerStep(data *WorkflowData) []string {
    // Processes: create_project, update_project, copy_project, create_project_status_update
    // via safe_output_project_handler_manager.cjs
}

The individual job builders were orphaned when this architecture was introduced but never cleaned up.

Original prompt

update-project and create-project-status-update should be ignore the "Process Project safe outputs" steps since they handled in the safe output unified handler.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

The update-project and create-project-status-update safe outputs are now handled by the unified project handler manager (buildProjectHandlerManagerStep). The individual job builders (buildUpdateProjectJob) were legacy code that was never called in production, only in tests.

Changes:
- Removed pkg/workflow/update_project_job.go (legacy job builder)
- Removed pkg/workflow/update_project_test.go (tests for removed builder)
- Removed pkg/workflow/update_project_token_test.go (tests for removed builder)
- Updated pkg/workflow/safe_outputs_integration_test.go to remove update_project test case

The configuration parsing functions (parseUpdateProjectConfig, parseCreateProjectStatusUpdateConfig) remain as they are used by the unified handler manager.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update project to skip processing safe outputs Remove legacy update-project job builder - now handled by unified handler Feb 1, 2026
Copilot AI requested a review from pelikhan February 1, 2026 11:48
@pelikhan pelikhan marked this pull request as ready for review February 1, 2026 11:50
@pelikhan
Copy link
Contributor

pelikhan commented Feb 1, 2026

@copilot recompile

Copy link
Contributor Author

Copilot AI commented Feb 1, 2026

@copilot recompile

Recompile completed successfully ✓ All 147 workflows compiled without errors or changes.

@pelikhan pelikhan merged commit 61f9632 into main Feb 1, 2026
146 checks passed
@pelikhan pelikhan deleted the copilot/ignore-process-project-steps branch February 1, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants