Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 1, 2026

Summary

Fixed an issue where messages from custom safe output jobs (defined in safe-outputs.jobs) were incorrectly triggering warnings in the unified and project handler managers.

Changes

  • safe_output_helpers.cjs: Added loadCustomSafeOutputJobTypes() function to parse GH_AW_SAFE_OUTPUT_JOBS env var (shared helper for both handler managers)
  • Both handler managers: Import and use loadCustomSafeOutputJobTypes() from helper file (removed duplicate implementations)
  • Message processing loops: Check if message type matches custom job type and skip with debug logging (same pattern as STANDALONE_STEP_TYPES)
  • Tests: Moved tests to safe_output_helpers.test.cjs for centralized testing

How It Works

  1. Compiler sets GH_AW_SAFE_OUTPUT_JOBS as JSON map of job names → output keys
  2. Handler managers parse this on startup using shared helper function
  3. During message processing, check if type matches custom job
  4. Custom job messages are skipped (similar to STANDALONE_STEP_TYPES)
  5. Prevents spurious "unknown message type" warnings

Example

For workflow with:

safe-outputs:
  jobs:
    notion-add-comment:
      inputs:
        page_id: { type: string }
        comment: { type: string }

Messages with type: "notion_add_comment" are properly recognized and skipped by handler managers.

Validation

  • ✅ All 46 safe_output_helpers tests passing (including new tests)
  • ✅ All 7 unified handler manager tests passing
  • ✅ Formatting and linting passed
  • ✅ Merged with main branch
  • ✅ All 147 workflows recompiled successfully
Original prompt

safe-outputs.jobs need to be accounted for when running the safe output unified handler loop or the project handler loop. They are valid messages that need to be ignored as they are process in other jobs.

Make sure the JavaScript knows about those and properly ignores them.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 1, 2026 10:15
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Update JavaScript to ignore safe outputs jobs Ignore safe-outputs.jobs messages in handler managers Feb 1, 2026
Copilot AI requested a review from pelikhan February 1, 2026 10:25
* These are job names defined in safe-outputs.jobs that are processed by custom jobs
* @returns {Set<string>} Set of custom safe output job type names
*/
function loadCustomSafeOutputJobTypes() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot move to helper file for safe output jobs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved loadCustomSafeOutputJobTypes() to safe_output_helpers.cjs and updated both handler managers to import it from the shared helper file. Tests were also moved to safe_output_helpers.test.cjs for centralized testing. Commit 59ec8b2

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan February 1, 2026 10:43
@pelikhan
Copy link
Contributor

pelikhan commented Feb 1, 2026

@copilot merge main and recompile

Copy link
Contributor Author

Copilot AI commented Feb 1, 2026

@copilot merge main and recompile

Merged main branch and recompiled all 147 workflows successfully. Commit e2b73de

@pelikhan pelikhan added the smoke label Feb 1, 2026
@pelikhan pelikhan marked this pull request as ready for review February 1, 2026 10:56
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Agent Container Tool Smoke Test

Tool Status Version
bash 5.2.21
sh available
git 2.52.0
jq 1.7
yq v4.50.1
curl 8.5.0
gh 2.86.0
node 24.13.0
python3 3.13.11
go 1.24.12
java not found
dotnet not found

Result: 10/12 tools available ❌

Missing Tools:

  • java - Java runtime not installed
  • dotnet - .NET runtime not installed

Available Core Tools:

  • Shell tools (bash, sh)
  • Version control (git)
  • JSON/YAML processing (jq, yq)
  • HTTP tools (curl)
  • GitHub CLI (gh)
  • Programming runtimes (node, python3, go)

AI generated by Agent Container Smoke Test

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

PRs: Add Serena MCP tool usage statistical analysis with request/response size metrics | Merge main branch and recompile workflows
GitHub MCP merged PRs: ✅
Safeinputs gh pr list: ✅
Serena activate: ✅; Playwright title: ✅; Tavily search: ✅
File write+cat: ✅; Discussion query+comment: ✅; Build: ✅
Overall: PASS

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

Smoke Test Results

PRs Tested:

Test Results:

  • ✅ GitHub MCP Testing
  • ✅ Safe Inputs GH CLI Testing
  • ✅ Serena MCP Testing
  • ✅ Make Build Testing
  • ✅ Playwright Testing
  • ✅ Tavily Web Search Testing
  • ✅ File Writing Testing
  • ✅ Bash Tool Testing
  • ✅ Discussion Interaction Testing

Overall Status: PASS

AI generated by Smoke Claude

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@pelikhan pelikhan merged commit 2f7cc81 into main Feb 1, 2026
131 of 132 checks passed
@pelikhan pelikhan deleted the copilot/ignore-safe-outputs-jobs branch February 1, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants