Fix test capturing stdout when version output moved to stderr #12750
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version command was changed to output to stderr instead of stdout in PR #12704, but the test was still using cmd.Output() which only captures stdout. Changed to cmd.CombinedOutput() to capture both stdout and stderr, fixing the test failure. Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue in action step execution
Fix test capturing stdout when version output moved to stderr
Jan 30, 2026
This was referenced Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #12704 routed version command output to stderr (diagnostic output convention), breaking
TestMainFunctionExecutionPath/main_function_basic_execution_flowwhich usedcmd.Output()to capture only stdout.Changes
cmd.CombinedOutput()to capture both stdout and stderrThis aligns with the pattern used in other integration tests (e.g.,
pkg/cli/completion_integration_test.go) for commands that may output to either stream.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.