Document typed slice patterns and complete interface{} migration

[Copilot]

Tool configuration types (GitHubToolName, GitHubAllowedTools, etc.) provide compile-time safety but were undocumented. Additionally, interface{} remained in production code despite Go 1.18+ any being standard.

Changes

specs/go-type-patterns.md

• Added "Tool Configuration Types" section documenting typed slice pattern:

  // Semantic type + typed slice with conversion helpers
  type GitHubToolName string
  type GitHubAllowedTools []GitHubToolName
  
  func (g GitHubAllowedTools) ToStringSlice() []string { ... }

• Documented typed slices vs []any decision criteria
• Added before/after migration examples showing benefits
• Updated summary tables with tool configuration domain

pkg/workflow/copilot_logs.go

• Replaced map[string]interface{} → map[string]any (2 occurrences)

AGENTS.md

• Added pkg/workflow semantic types section listing tool configuration types

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[plan] Document type pattern guidelines and complete migration</issue_title>
<issue_description>## Objective

Document the new type patterns established by the previous issues and complete any remaining interface{} to any migrations for consistency.

Context

From discussion #10816: After implementing typed slices for tool configurations, we need to:

1. Document the new patterns in the codebase
2. Complete the migration from interface{} to any for Go 1.18+ consistency
3. Update specs/go-type-patterns.md with examples from the refactoring

Approach

1. Update specs/go-type-patterns.md:

   • Add examples of semantic types for tool configurations (BashCommand, GitHubToolName, etc.)
   • Document when to use typed slices vs []any
   • Show before/after examples from the refactoring

2. Update AGENTS.md if needed:

   • Reference the new semantic types in pkg/constants or pkg/workflow
   • Update type pattern guidance

3. Search for remaining interface{} usages:

   grep -r "interface{}" pkg/ --include="*.go" | grep -v "_test.go"

4. Replace interface{} with any where appropriate:

   • Focus on non-test files
   • Keep legitimate uses in test files (acceptable)
   • Exclude cases where interface{} is required for reflection

5. Run full test suite to verify changes

Files to Modify

• Update: specs/go-type-patterns.md (add semantic type examples)
• Update: AGENTS.md (if needed for type pattern guidance)
• Update: Any files with interface{} → any changes
• Review: All pkg/*.go files for interface{} usage

Acceptance Criteria

• specs/go-type-patterns.md includes examples of semantic types from tool configuration
• Guidance on when to use typed slices vs []any is documented
• Remaining interface{} in non-test files are migrated to any
• All existing tests pass
• Run make agent-finish successfully before committing

AI generated by Plan Command for discussion #10816

Comments on the Issue (you are @copilot in this section)

• Fixes [plan] Document type pattern guidelines and complete migration #10829

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.