Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 15, 2026

PR #10128 changed load_agent_output.cjs to use core.info instead of core.error for missing agent output files. The test in load_agent_output.test.cjs was updated, but noop.test.cjs was missed, causing a test failure.

Changes

  • actions/setup/js/noop.test.cjs: Updated should handle missing agent output file test to expect mockCore.info instead of mockCore.error

Context

The CI Failure Doctor report incorrectly attributed this to PR #10125 and claimed "43 tests failing". Actual failure was a single test in noop.test.cjs caused by PR #10128's logging behavior change.

// Before (incorrect after PR #10128)
expect(mockCore.error).toHaveBeenCalledWith(expect.stringContaining("Error reading agent output file"));

// After (matches new behavior)
expect(mockCore.info).toHaveBeenCalledWith(expect.stringContaining("Error reading agent output file"));
Original prompt

This section details on the original issue you should resolve

<issue_title>[CI Failure Doctor] JS validation regression after PR #10125 - 43 tests failing</issue_title>
<issue_description># 🏥 CI Failure Investigation - Run githubnext/gh-aw#21046376185

Summary

CRITICAL REGRESSION: JavaScript validation is completely broken after PR #10125. 43 tests failing, validation not rejecting invalid data.

Failure Details

  • Run: #21046376185
  • Commit: 5531197 (only docs changes)
  • Failed Job: js (43 test failures)
  • Severity: CRITICAL (security issue)

Timeline

20:51:37Z - PR #10125 merged
21:07:02Z - Commit 5531197 pushed
21:07:07Z - CI FAILED

Root Cause

PR #10125 broke validation in collect_ndjson_output.cjs. Tests expect validation errors, get empty arrays. INVALID DATA PASSING VALIDATION.

Test Failures

  • 36: collect_ndjson_output.test.cjs (validation broken)
  • 2: MCP server timeouts
  • 1: Missing error handling
  • 4: Go binary not found

Actions

  1. Investigate PR Fix JavaScript test failures: schema validation and missing template files #10125 validation changes
  2. Consider reverting
  3. Restore validation logic

Prevention

NEVER weaken validation to pass tests. Fix root cause, run full tests, verify CI.

AI generated by CI Failure Doctor

To add this workflow in your repository, run gh aw add githubnext/agentics/workflows/ci-doctor.md@ea350161ad5dcc9624cf510f134c6a9e39a6f94d. See usage guide.

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits January 15, 2026 22:05
…hange

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…ng files

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix JavaScript validation regression after PR #10125 Fix noop.test.cjs to match load_agent_output logging behavior change Jan 15, 2026
Copilot AI requested a review from mnkiefer January 15, 2026 22:12
@pelikhan pelikhan marked this pull request as ready for review January 15, 2026 23:33
@pelikhan pelikhan closed this Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI Failure Doctor] JS validation regression after PR #10125 - 43 tests failing

3 participants