Skip to content

feat(artifacts): surface activation context and inventory - #747

Merged
davidslater merged 3 commits into
mainfrom
ace/01KZ72BRJTW4HY612AXN8306R5
Aug 4, 2026
Merged

feat(artifacts): surface activation context and inventory#747
davidslater merged 3 commits into
mainfrom
ace/01KZ72BRJTW4HY612AXN8306R5

Conversation

@davidslater

Copy link
Copy Markdown
Collaborator

Created by GitHub Ace · View Session

Summary

  • expose a bounded, allowlisted subset of aw_info.json as explicitly untrusted activation context
  • recursively inventory all artifact files in JSONL logs and the GitHub Actions step summary
  • document experiments/ and comment-memory/ as inventory-only inputs and align the specifications

Validation

  • make fmt lint build test
  • make security-govulncheck

Closes #704

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 4, 2026 21:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds bounded activation context and recursive artifact inventory observability.

Changes:

  • Parses allowlisted aw_info.json metadata as untrusted prompt context.
  • Logs all artifact files and writes an Actions summary table.
  • Aligns specifications, documentation, and tests.
Show a summary per file
File Description
pkg/artifacts/artifacts.go Loads activation context and builds inventory.
pkg/artifacts/artifacts_test.go Tests parsing, limits, and inventory.
pkg/detector/detector.go Renders activation context.
pkg/detector/static.go Classifies context as untrusted.
pkg/detector/prompts/threat_detection.md Adds activation-context guidance.
pkg/detector/detector_test.go Tests prompt inclusion.
pkg/stepsummary/stepsummary.go Writes the inventory summary table.
cmd/threat-detect/main.go Logs and summarizes inventory.
cmd/threat-detect/logfile_test.go Tests logging and summary failures.
specs/threat-detection-spec.md Defines activation and inventory requirements.
specs/usage-spec.md Documents host integration.
README.md Updates user-facing artifact behavior.
DEVGUIDE.md Updates developer guidance.
CLAUDE.md Updates repository agent guidance.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 14/14 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment on lines +55 to +60
replacer := strings.NewReplacer(
"\\", "\\\\",
"|", "\\|",
"\r", "\\r",
"\n", "\\n",
)
…ection

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
@davidslater
davidslater merged commit 47f768e into main Aug 4, 2026
8 checks passed
@davidslater
davidslater deleted the ace/01KZ72BRJTW4HY612AXN8306R5 branch August 4, 2026 21:54
davidslater added a commit that referenced this pull request Aug 4, 2026
main's #747 introduced a TD-20c (append the artifact inventory to
GITHUB_STEP_SUMMARY) while this branch had already defined TD-20c for the
conclude diagnostics — two different normative requirements under one ID.

main's TD-20c keeps the ID since it is already published; the conclude
diagnostics requirement is renumbered to TD-20d, and the U-18a cross-reference
in specs/usage-spec.md is updated to match. The unrelated TD-20c reference at
U-09 (step-summary inventory) is intentionally left pointing at TD-20c.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: David Slater <12449447+davidslater@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parity: documented artifacts aw_info.json and experiments/ are never loaded or surfaced

2 participants