Conversation
…xt codex override Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
|
@copilot also fix smoke-copilot and smoke-codex |
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Done in 5de70e8. Applied the same fix to both Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot the .md file for the agentic workflow has to be updated. you cannot update the .lock.yml directly |
There was a problem hiding this comment.
Pull request overview
This PR fixes a configuration issue preventing Serena MCP server tools from being available in language support testing workflows for Go, TypeScript, and Python. The root cause was twofold: (1) using --context codex flag via custom entrypoint that prevented tool registration, and (2) mounting the workspace at the wrong path preventing Serena's initialization script from finding the project.
Changes:
- Removed custom entrypoint/entrypointArgs overrides for Serena MCP server configuration
- Corrected workspace mount path from
${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE}:rwto${GITHUB_WORKSPACE}:/workspace:rw - Applied fixes to three workflow lock files enabling the default
serena-init.shentrypoint to properly initialize multi-language support
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/language-support-tester.lock.yml |
Fixed Serena MCP server configuration to use default entrypoint and correct workspace mount path |
.github/workflows/smoke-copilot.lock.yml |
Applied same Serena MCP server configuration fixes as language-support-tester |
.github/workflows/smoke-codex.lock.yml |
Applied Serena MCP server configuration fixes in both TOML and JSON config sections |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "entrypoint": "serena", | ||
| "entrypointArgs": ["start-mcp-server", "--context", "codex", "--project", "\${GITHUB_WORKSPACE}"], | ||
| "mounts": ["\${GITHUB_WORKSPACE}:\${GITHUB_WORKSPACE}:rw"] | ||
| "mounts": ["\${GITHUB_WORKSPACE}:/workspace:rw"] |
There was a problem hiding this comment.
Multiple other workflow files still have the incorrect Serena MCP server configuration that this PR fixes. The following files should also be updated to remove the entrypoint/entrypointArgs and correct the mount path:
.github/workflows/duplicate-code-detector.lock.yml(lines 689-691).github/workflows/go-fan.lock.yml(lines 663-665).github/workflows/nightly-docs-reconciler.lock.yml(lines 636-638).github/workflows/test-improver.lock.yml(lines 662-664).github/workflows/test-coverage-improver.lock.yml(lines 663-665)
These files all have the same problematic pattern:
"entrypoint": "serena",
"entrypointArgs": ["start-mcp-server", "--context", "codex", "--project", "${GITHUB_WORKSPACE}"],
"mounts": ["${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE}:rw"]
They should be updated to match the fix in this PR:
"mounts": ["${GITHUB_WORKSPACE}:/workspace:rw"]
This will ensure Serena tools are available in all workflows that use the Serena MCP server.
Fixes the Serena MCP server tools (
serena-get_symbols_overview,serena-find_symbol, etc.) not being available in the agent environment for Go, TypeScript/JavaScript, and Python language support testing.Root Cause
The
--context codexflag passed viaentrypointArgsto the Serena MCP server prevented it from properly registering tools in the MCP gateway. Additionally, mounting the workspace at${GITHUB_WORKSPACE}:${GITHUB_WORKSPACE}:rwinstead of${GITHUB_WORKSPACE}:/workspace:rwmeant Serena's defaultserena-init.shentrypoint couldn't find the project at the expected/workspacepath.Changes Made
Removed the
entrypoint/entrypointArgsoverride and corrected the workspace mount path in three workflow lock files:.github/workflows/language-support-tester.lock.yml— primary workflow where the issue was reported.github/workflows/smoke-copilot.lock.yml— had the same misconfiguration.github/workflows/smoke-codex.lock.yml— had the same misconfiguration in both its TOML and JSON config sectionsThe fix uses the container's default
serena-init.shentrypoint, which creates/workspace/.serena/project.ymlwith Go, TypeScript, and Python language support, then runsserena-mcp-serverso all tools are properly registered with theserena-prefix.Testing
make agent-finished)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.