Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions .github/agentics/language-support-tester.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,31 +11,32 @@ Test that Go, TypeScript/JavaScript, and Python programming language support wor

## Step 1: Test Go Language Support

1. **Activate the Go project** using Serena's `activate_project` tool with the Go language
1. **Activate the Go project** using the `serena-activate_project` tool with the workspace path from github-context
2. **Verify Go tooling works**:
- Use Serena to analyze Go files in the `internal/` directory
- Try to find functions, types, or symbols in Go code
- Check that Go language server responds correctly
- Use the `serena-find_symbol` tool to locate functions, types, or symbols in Go files under the `internal/` directory
- Use the `serena-get_symbols_overview` tool to get a high-level overview of a Go source file
- Check that the Go language server responds correctly
3. **Document results**: Note any errors, failures, or unexpected behavior

## Step 2: Test TypeScript/JavaScript Language Support

1. **Activate a TypeScript/JavaScript project** using Serena's `activate_project` tool
1. **Activate a TypeScript/JavaScript project** using the `serena-activate_project` tool
- Use the test samples at `{workspace}/test/serena-mcp-tests/samples/js_project/` (use the workspace path from github-context)
2. **Verify TypeScript/JavaScript tooling works**:
- Use Serena to analyze JavaScript/TypeScript files
- Try to find functions or symbols in the JavaScript code
- Check that TypeScript/JavaScript language server responds correctly
- Use the `serena-find_symbol` tool to locate functions or symbols in the JavaScript files
- Use the `serena-get_symbols_overview` tool to get an overview of a JavaScript file
- Check that the TypeScript/JavaScript language server responds correctly
3. **Document results**: Note any errors, failures, or unexpected behavior

## Step 3: Test Python Language Support

1. **Activate a Python project** using Serena's `activate_project` tool with the Python language
1. **Activate a Python project** using the `serena-activate_project` tool with the Python language
- Use the test samples at `{workspace}/test/serena-mcp-tests/samples/python_project/` (use the workspace path from github-context)
2. **Verify Python tooling works**:
- Use Serena to analyze Python files (`calculator.py`, `utils.py`)
- Try to find functions, classes, or symbols in Python code (e.g., `Calculator` class, `add` method, `format_number` function)
- Check that Python language server responds correctly
- Use the `serena-find_symbol` tool to locate functions, classes, or symbols in Python files (`calculator.py`, `utils.py`)
- Try finding symbols like the `Calculator` class, `add` method, or `format_number` function
- Use the `serena-get_symbols_overview` tool to get an overview of a Python file
- Check that the Python language server responds correctly
3. **Document results**: Note any errors, failures, or unexpected behavior

## Step 4: Report Results
Expand All @@ -55,15 +56,15 @@ Test that Go, TypeScript/JavaScript, and Python programming language support wor

## Testing Guidelines

- **Use Serena MCP tools directly** - Don't use bash to run language commands
- **Test real functionality** - Use tools like `find_symbols`, `get_definition`, `activate_project`
- **Use Serena MCP tools directly** - Don't use bash to run language commands; use `serena-activate_project`, `serena-find_symbol`, `serena-get_symbols_overview` etc.
- **Test real functionality** - Use tools like `serena-find_symbol`, `serena-get_symbols_overview`, `serena-activate_project`
- **Be thorough** - Test multiple operations for each language
- **Clear error reporting** - If something fails, capture the exact error message
- **One issue per run** - If multiple languages fail, create one issue covering all failures

## Available Tools

- **Serena MCP Server**: Use for Go, TypeScript/JavaScript, and Python language analysis
- **Serena MCP Server**: Tools are prefixed with `serena-` (e.g., `serena-activate_project`, `serena-find_symbol`, `serena-get_symbols_overview`, `serena-search_for_pattern`)
- **GitHub Tools**: Use to query repository information if needed
- **Safe Outputs**: Use `create-issue` to report problems

Expand Down
6 changes: 2 additions & 4 deletions internal/server/sdk_logging_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,8 @@ func makeJSONRPCRequest(method string, id interface{}) []byte {

// handlerCapture is a helper to track what an inner handler received.
type handlerCapture struct {
called bool
body []byte
statusCode int
responseBody []byte
called bool
body []byte
}

// makeInnerHandler creates an http.Handler that records the request body and returns the given response.
Expand Down
Loading