feat: allow empty allowDomains to block all network access#451
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
|
@copilot add more integration tests to test the awf with empty domains |
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Added integration tests in
|
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
Coverage comparison generated by |
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
Smoke Test Results (Run 21529827614) ✅ GitHub MCP: #448 feat(cli): add --enable-chroot for transparent host binary execution Status: PASS cc @Mossaka
|
|
Smoke Test Results - Claude Engine ✅ GitHub MCP: #450 ci: add npm registry auth, #449 chore: bump version to 0.1.5 Overall: PASS
|
❌ Smoke Test: Chroot Runtime Verification - Cannot RunThis smoke test cannot be executed in the current GitHub Actions environment due to security restrictions. IssueThe environment has the
Host Versions CapturedAlternativesTo properly test
RecommendationConsider adding a separate workflow job specifically for chroot testing with appropriate permissions, or run this test manually on a development machine where sudo/chroot is available.
|
|
@copilot-swe-agent review |
|
@copilot please merge origin/main |
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
* Initial plan * feat: allow empty allowDomains to block all network access Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> * test: add integration tests for empty domains (no network access) Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> * test: fix misleading test title for DNS behavior test Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> * ci: re-trigger workflow checks * chore: merge origin/main and fix integration test Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com> Co-authored-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
--allow-domainspreviously required at least one domain. Users need the ability to run commands with no network access.Changes
src/cli.ts: Remove validation requiring ≥1 domain; add debug log when no domains specifiedsrc/squid-config.test.ts: Add test verifying empty domains generateshttp_access deny alltests/integration/empty-domains.test.ts: Add integration tests verifying network blocking, offline commands, and debug output when no domains are specifieddocs/usage.md,docs-site/.../cli-reference.md: Update docs to reflect optional natureUsage
The squid config generator already handled empty domain lists correctly (
http_access deny all); only the CLI validation was blocking this use case.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.