feat: add localhost keyword for playwright testing by Copilot · Pull Request #427 · github/gh-aw-firewall

Copilot · 2026-01-26T21:02:49Z

Playwright tests against local dev servers required manual configuration of host access, domain mapping, and port allowlists. The localhost keyword now auto-configures this setup.

Changes

CLI Enhancement (src/cli.ts)

localhost in --allow-domains automatically:
- Maps to host.docker.internal (preserves http:// / https:// prefixes)
- Enables --enable-host-access
- Allows common dev ports: 3000, 3001, 4000, 4200, 5000, 5173, 8000, 8080, 8081, 8888, 9000, 9090
- User override via --allow-host-ports still respected

Container Fix (containers/agent/setup-iptables.sh)

Removed multiport module from port range rules (not supported by iptables DNAT)

Testing (tests/integration/localhost-access.test.ts)

8 test cases covering auto-enable, protocol prefixes, custom ports, host resolution

Documentation

Added Playwright guide to docs-site
Updated README, usage docs, and AGENTS.md

Usage

# Before
sudo awf \
  --enable-host-access \
  --allow-domains host.docker.internal \
  --allow-host-ports 3000,8080 \
  -- npx playwright test

# After
sudo awf --allow-domains localhost,playwright.dev -- npx playwright test

Security warnings maintained for host access. Custom port lists still supported via --allow-host-ports.

Original prompt

This section details on the original issue you should resolve

<issue_title>Playwright testing</issue_title>
<issue_description>Texting a localhost web site should work out of the box.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Playwright testing #102

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

- Automatically maps 'localhost' to 'host.docker.internal' - Enables host access when localhost is specified - Configures common development ports (3000, 4200, 5173, 8080, etc.) - Supports protocol prefixes (http://localhost, https://localhost) - Preserves user-specified --allow-host-ports if provided - Add comprehensive integration tests for localhost functionality Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

- Add localhost keyword section to AGENTS.md - Add Playwright testing examples to README.md - Add comprehensive guide to docs/usage.md - Create dedicated Playwright testing guide in docs-site - Explain automatic configuration and security considerations Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Add localhost to --allow-domains help text explaining it auto-configures for local testing Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

github-actions · 2026-01-26T23:07:41Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-01-26T23:07:42Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-01-26T23:08:32Z

⚠️ Coverage Regression Detected

This PR decreases test coverage. Please add tests to maintain coverage levels.

Overall Coverage

Metric	Base	PR	Delta
Lines	77.98%	77.23%	📉 -0.75%
Statements	78.05%	77.32%	📉 -0.73%
Functions	77.77%	77.36%	📉 -0.41%
Branches	71.70%	70.64%	📉 -1.06%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/cli.ts`	40.1% → 37.8% (-2.24%)	40.3% → 38.0% (-2.24%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-01-26T23:10:06Z

Smoke Test Results

Last 2 merged PRs:

fix(deps): update js-yaml to 3.14.2 (CVE fix) #424: fix(deps): update js-yaml to 3.14.2 (CVE fix)
chore: remove unused release workflow files #423: chore: remove unused release workflow files

✅ GitHub MCP
✅ Playwright (title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
✅ File writing
✅ Bash tool

Status: PASS

cc @copilot @Mossaka

AI generated by Smoke Copilot

github-actions · 2026-01-26T23:10:30Z

Smoke Test Results (Claude Engine)

GitHub MCP:

fix(deps): update js-yaml to 3.14.2 (CVE fix) #424: fix(deps): update js-yaml to 3.14.2 (CVE fix)
chore: remove unused release workflow files #423: chore: remove unused release workflow files

Tests:
✅ GitHub MCP - Retrieved last 2 merged PRs
✅ Playwright - Verified page title "GitHub · Change is constant. GitHub keeps you ahead. · GitHub"
✅ File Writing - Created /tmp/gh-aw/agent/smoke-test-claude-21374333874.txt
✅ Bash Tool - Verified file contents

Status: PASS

AI generated by Smoke Claude

github-actions · 2026-01-26T23:10:50Z

Security Review: Localhost Keyword Feature

I've reviewed PR #427 for security implications. The implementation is generally sound with proper validation, but I found one security concern that should be addressed before merge.

🔴 Security Issue: Port 8888 in Default Port List

File: src/cli.ts (line 665)

Issue: The default localhost port list includes port 8888, which is commonly used by Jupyter Notebook/JupyterLab servers:

options.allowHostPorts = '3000,3001,4000,4200,5000,5173,8000,8080,8081,8888,9000,9090';

Security Risk:

Jupyter servers provide arbitrary code execution capabilities via notebooks
If a user has a Jupyter server running on their host machine while using the firewall, the localhost keyword would automatically grant AI agents access to it
This creates an unintended privilege escalation path where an agent could execute Python code on the host

Recommendation:

Remove port 8888 from the default list, OR
Add port 8888 to DANGEROUS_PORTS constant in src/squid-config.ts to block it entirely

Suggested fix:

// Remove 8888 from this line:
options.allowHostPorts = '3000,3001,4000,4200,5000,5173,8000,8080,8081,9000,9090';

Users who genuinely need Jupyter access can explicitly specify --allow-host-ports 8888 with full awareness of the security implications.

✅ Security Aspects That Are Safe

Port validation works correctly - All ports go through the existing DANGEROUS_PORTS check in squid-config.ts which blocks SSH (22), databases (3306, 5432, etc.), and other sensitive services
iptables bug fix is legitimate - The removal of -m multiport from DNAT rules (line 177 in setup-iptables.sh) is a valid fix since multiport doesn't support port ranges in DNAT context
Protocol preservation - HTTP/HTTPS prefixes are correctly preserved when mapping localhost to host.docker.internal
User override capability - Users can still customize with --allow-host-ports to override defaults
Host access intentional - The automatic enablement of --enable-host-access is documented with appropriate security warnings

Verdict

Conditional approval - Safe to merge after removing port 8888 from the default list. All other aspects of the implementation maintain the firewall's security posture.

AI generated by Security Guard

Mossaka · 2026-02-03T19:32:10Z

@copilot please merge origin/main

Mossaka · 2026-02-03T19:56:43Z

@copilot merge main and bump up the test coverage so https://github.com/github/gh-aw-firewall/actions/runs/21374333813/job/61536955621?pr=427 won't fail

Extract localhost processing logic into testable function and add comprehensive unit tests covering: - Plain localhost, http://localhost, https://localhost variants - Protocol prefix preservation - Host access auto-enablement - Default port configuration - Edge cases and domain order preservation Coverage improvements: - Overall: 81.58% → 82.03% (+0.45%) - cli.ts lines: 37.82% → 41.47% (+3.65%) - cli.ts branches: 31.03% → 38.01% (+6.98%) Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Mossaka

Review: REQUEST_CHANGES

@copilot Please fix the following security issue:

Issue: Missing Security Warning

When the localhost keyword auto-enables --enable-host-access, there should be a security warning. Currently, users may not realize they've exposed their host machine to the agent.

Required Fix

Add a security warning in src/cli.ts when localhost triggers host access:

if (localhostResult.shouldEnableHostAccess) {
  options.enableHostAccess = true;
  logger.warn('Security warning: localhost keyword enables host access - agent can reach services on your machine');
  logger.info('localhost keyword detected - automatically enabling host access');
}

Additional Suggestions

Handle multiple localhost variants consistently (e.g., if both localhost and http://localhost are specified)
Add an integration test verifying dangerous ports (SSH:22, databases) are still blocked when using localhost keyword
Consider reducing the default port list to truly common dev ports (3000, 5173, 8080) and require explicit --allow-host-ports for others

The feature is well-implemented otherwise - just needs the security warning.

# Conflicts: # src/cli.test.ts

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

…ght-testing

github-actions · 2026-02-04T20:00:58Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-02-04T20:01:00Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-02-04T20:01:00Z

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

github-actions · 2026-02-04T20:01:34Z

⚠️ Coverage Regression Detected

This PR decreases test coverage. Please add tests to maintain coverage levels.

Overall Coverage

Metric	Base	PR	Delta
Lines	82.44%	82.08%	📉 -0.36%
Statements	82.47%	82.12%	📉 -0.35%
Functions	81.77%	81.95%	📈 +0.18%
Branches	75.59%	75.41%	📉 -0.18%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/cli.ts`	40.5% → 41.7% (+1.22%)	40.7% → 41.9% (+1.20%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-02-04T20:03:36Z

Smoke Test Results

Last 2 Merged PRs:

chore: upgrade agentic workflows to gh-aw v0.42.0 #512: chore: upgrade agentic workflows to gh-aw v0.42.0
fix: replace deprecated log_access directive with Squid 5+ syntax #506: fix: replace deprecated log_access directive with Squid 5+ syntax

Test Results:
✅ GitHub MCP Testing
✅ Playwright Testing (title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
✅ File Writing Testing
✅ Bash Tool Testing

Overall Status: PASS

cc @Mossaka

AI generated by Smoke Copilot

github-actions · 2026-02-04T20:03:40Z

Smoke Test Results - Claude Engine

Last 2 Merged PRs:

chore: upgrade agentic workflows to gh-aw v0.42.0 #512: chore: upgrade agentic workflows to gh-aw v0.42.0
fix: replace deprecated log_access directive with Squid 5+ syntax #506: fix: replace deprecated log_access directive with Squid 5+ syntax

Test Results:

✅ GitHub MCP: Retrieved PR data
✅ Playwright: Navigated to GitHub, title verified
✅ File Write: Created test file successfully
✅ Bash: Verified file contents

Status: PASS

AI generated by Smoke Claude

Initial plan

f3403bf

Copilot AI assigned Copilot and Mossaka Jan 26, 2026

Copilot started work on behalf of Mossaka January 26, 2026 21:03 View session

Copilot AI and others added 3 commits January 26, 2026 21:16

docs: update CLI help text for localhost keyword

f0db83f

Add localhost to --allow-domains help text explaining it auto-configures for local testing Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add Playwright testing for localhost web site~~ feat: add localhost keyword for playwright testing Jan 26, 2026

Copilot AI requested a review from Mossaka January 26, 2026 21:21

Copilot finished work on behalf of Mossaka January 26, 2026 21:21

Mossaka marked this pull request as ready for review January 26, 2026 23:07

github-actions bot added the smoke-copilot label Jan 26, 2026

github-actions bot added the smoke-claude label Jan 26, 2026

Copilot and others added 2 commits February 3, 2026 19:59

merge: resolve conflicts from origin/main

6b2e53e

Mossaka requested changes Feb 4, 2026

View reviewed changes

Copilot AI and others added 4 commits February 4, 2026 17:17

merge: sync with origin/main

92cf5bc

# Conflicts: # src/cli.test.ts

fix: add security warning for localhost keyword host access

079ab78

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

test: verify security warning in localhost integration test

e7abfc2

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into copilot/setup-playwri…

be36b68

…ght-testing

Mossaka merged commit 1c50236 into main Feb 4, 2026
45 of 47 checks passed

Mossaka deleted the copilot/setup-playwright-testing branch February 4, 2026 20:15

Conversation

Copilot AI commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Usage

Comments on the Issue (you are @copilot in this section)

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 26, 2026

⚠️ Coverage Regression Detected

Overall Coverage

Uh oh!

github-actions bot commented Jan 26, 2026

Smoke Test Results

Uh oh!

github-actions bot commented Jan 26, 2026

Uh oh!

github-actions bot commented Jan 26, 2026

Security Review: Localhost Keyword Feature

🔴 Security Issue: Port 8888 in Default Port List

✅ Security Aspects That Are Safe

Verdict

Uh oh!

Mossaka commented Feb 3, 2026

Uh oh!

Mossaka commented Feb 3, 2026

Uh oh!

Mossaka left a comment

Choose a reason for hiding this comment

Review: REQUEST_CHANGES

Issue: Missing Security Warning

Required Fix

Additional Suggestions

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 4, 2026

⚠️ Coverage Regression Detected

Overall Coverage

Uh oh!

github-actions bot commented Feb 4, 2026

Smoke Test Results

Uh oh!

github-actions bot commented Feb 4, 2026

Smoke Test Results - Claude Engine

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Jan 26, 2026 •

edited

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading

github-actions bot commented Feb 4, 2026 •

edited

Loading