Fix image filename lookups for default emoji. #78
Conversation
|
Thanks. To be clear, this normalizes the filenames of default, yellow emoji to not have ".0" suffix, right? |
|
Yup. And when I say "fixes" the lookups, that's cause based on just the base emoji, you'd expect its name to not have any suffix—you wouldn't have any way of knowing that it even could be modified. (Without modifying the emoji database to hardcode that. I tried running the database regeneration script to see if maybe lookups would work afterward and they didn't seem to… not sure if I regenerated it right.) |
|
This PR does not implement support for the non-default emoji. I've changed the PR name and commit message to be more clear. |
wearhere
changed the title
wearhere
force-pushed
the
jeff/fix_skin_tone_emoji
branch
from
73ab748 to
76ccb20
Compare
| # When an emoji supports skin-tone modifiers, all variants--including | ||
| # the unmodified "base" emoji--are suffixed with a "." + a number: | ||
| # 0 for the base, then 1-5 for Fitzpatrick type | ||
| # (https://en.wikipedia.org/wiki/Fitzpatrick_scale) 2-6. We remove the |
There was a problem hiding this comment.
1f44b.1.png corresponds to 👋 in shade Fitzpatrick type II, 1f44b.2.png to Fitzpatrick type III, and so on.
There was a problem hiding this comment.
Thanks for the clarification. Can you make this more explicit so future readers don't get confused like me? Maybe word it like:
Then 1-5 which maps to Fitzpatrick types 2-6 (link)
There was a problem hiding this comment.
No problem. Updated.
"Default emoji" == emoji that can be modified with skin tone modifiers.
wearhere
force-pushed
the
jeff/fix_skin_tone_emoji
branch
from
76ccb20 to
859778c
Compare
Fix image filename lookups for default emoji.
|
Thanks! |
No description provided.