-
Notifications
You must be signed in to change notification settings - Fork 785
Resolve the emoji.json "unicodes" mess #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Otherwise canvas element defaults to a larger size.
We now operate on a new set of assumptions: - Characters with VARIATION_SELECTOR_15 shouldn't render as emoji, even if OS X doesn't respect that currently. This removes explicit aliases that include VARIATION_SELECTOR_15. - VARIATION_SELECTOR_16 is optional for most characters to render as emoji on OS X. For those that *don't* have it optional, we include VARIATION_SELECTOR_16 in their raw representation in `emoji.json`. Other characters list their form including VARIATION_SELECTOR_16 implicitly in `unicode_aliases`. - For emoji that consist of 2 characters + variation selector, we assume that the selector can come between the 2 characters or *after* them, so `find_by_unicode` now supports both forms. - The `db/aliases.html` script ensures that `emoji.json` only contains characters that Safari on OS X actually renders as emojis.
Nice! |
@aroben: Important question: just because OS X renders some emoji even when not suffixed with VARIATION_SELECTOR_16, I'm wondering whether we should. Although a character like |
Yeah, the fact that it's all font-dependent makes it pretty tricky. We could just never replace native emoji with images inside monospaced text. |
We'll take care of it in client code then, at least when it comes to Alright I think I'm going to 🔫 first and ask questions later with this PR. |
👍 |
You mean in js or the ruby rewriter? It seems like anything in a |
Right now we do insert
But we could stop doing it. Anyway, further discussion about this will continue in a more appropriate place. |
👍 |
Resolve the emoji.json "unicodes" mess
We now operate on a new set of assumptions:
emoji.json
. Other characters list their form including VARIATION_SELECTOR_16 implicitly inunicode_aliases
.find_by_unicode
now supports both forms.db/aliases.html
script ensures thatemoji.json
only contains characters that Safari on OS X actually renders as emojis.This eliminates the need to have
unicodes
key in emoji.json, which simplifies things a bit.Reverts parts of #56 but continues in the same philosophy: only render emojis that OS X renders by default.
/cc @aroben