Skip to content

Update xonsh shell icons#4933

Merged
jmeridth merged 9 commits intogithub:mainfrom
anki-code:patch-1
Nov 17, 2025
Merged

Update xonsh shell icons#4933
jmeridth merged 9 commits intogithub:mainfrom
anki-code:patch-1

Conversation

@anki-code
Copy link
Contributor

@anki-code anki-code commented Nov 14, 2025

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Two changes:

  1. xonsh topic image - it's just updating the icons to set the style like in https://github.com/xonsh/
  2. xontrib topic image - it's refreshing the old image.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Copilot AI review requested due to automatic review settings November 14, 2025 06:18
@anki-code anki-code requested a review from a team as a code owner November 14, 2025 06:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anki-code anki-code changed the title Update xonsh shell icon Update xonsh shell icons Nov 15, 2025
Mahdi99mi

This comment was marked as spam.

@anki-code anki-code requested a review from Mahdi99mi November 15, 2025 16:33
@jmeridth
Copy link
Contributor

jmeridth commented Nov 17, 2025

@anki-code I saw you updated the readme on the project to the new icon but the website still shows the old icon. Is that getting updated later or the project will have different icons (one for README and one for website)? More out of curiousity. 😄

@anki-code
Copy link
Contributor Author

Hey @jmeridth! You noticed correctly! We're updating the icon step by step: the GitHub repo, the Zulip community, the AppImage, the GitHub topic.
The website has a design concept with waves and a conch, so we're thinking about how we can integrate the new icon in the future.

From a top-level view, this is how we think about xonsh identity:
image

@jmeridth jmeridth added this pull request to the merge queue Nov 17, 2025
Merged via the queue into github:main with commit 3d8916d Nov 17, 2025
5 checks passed
@anki-code
Copy link
Contributor Author

anki-code commented Dec 5, 2025

Is that getting updated later or the project will have different icons (one for README and one for website)? More out of curiousity.

To satisfy your curiosity, we got out of the dilemma in this way (dev):

image

Copy link

@Mahdi99mi Mahdi99mi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bc1qr8e6kmev99jxnk7hpyhex434t59ke5tpvmnyd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants