Conversation
Signed-off-by: Adam Rofayel <adamrofayel@gmail.com>
Signed-off-by: Adam Rofayel <adamrofayel@gmail.com>
Contributor
|
There is already https://github.com/collections/dil-dil-pakistan |
Contributor
Author
|
It should be labeled as 'Made in Pakistan' like all others, so it's easy to find. I couldn't even find it; there's no search on the collections page. And for those not from Pakistan, 'Dil Dil Pakistan' is not a good name to represent Open Source contributions of Pakistan. It literally means 'Pakistan is my heart', which should not be the title of such a collection. |
Contributor
|
@imrofayel that is a very valid point. i'll merge this one and add the items from the other one to it. |
ahpook
approved these changes
Mar 31, 2025
ahpook
added a commit
that referenced
this pull request
Mar 31, 2025
This should be consistent with the other country-based collections Relates to #4674
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:
*.png, square, dimensions 288x288, size <= 75 kB)index.md)Curating a new topic or collection
https://github.com/topics/[NAME]orhttps://github.com/collections/[NAME])*.pngimage (if applicable) andindex.mdindex.mdconform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docsSomething that does not neatly fit into the binary options above
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.