Skip to content

Comments

Genshin Impact topic: add logo#4607

Merged
kenyonj merged 6 commits intogithub:mainfrom
oxygen-dioxide:genshin
Jan 29, 2025
Merged

Genshin Impact topic: add logo#4607
kenyonj merged 6 commits intogithub:mainfrom
oxygen-dioxide:genshin

Conversation

@oxygen-dioxide
Copy link
Contributor

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@oxygen-dioxide oxygen-dioxide requested a review from a team as a code owner January 29, 2025 12:14
@oxygen-dioxide
Copy link
Contributor Author

oxygen-dioxide commented Jan 29, 2025

How to make it less than 75kb while keeping the image dimensions 288*288?

@kenyonj
Copy link
Contributor

kenyonj commented Jan 29, 2025

As you've seen, an image like this doesn't translate well with our restraints. Perhaps we can use one of the transparent logotype pngs you can find online? I just grabbed a transparent one and edited the canvas size to be 288x288, what do you think of this? (it's 28kb)
Genshin Impact Logo (3) (1)

Copy link
Contributor

@kenyonj kenyonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@oxygen-dioxide
Copy link
Contributor Author

We can't directly use the transparent logo here, because it looks strange if the user uses a bright theme:
image

@oxygen-dioxide
Copy link
Contributor Author

Added a black background to this image:
genshin-impact

@kenyonj
Copy link
Contributor

kenyonj commented Jan 29, 2025

We can't directly use the transparent logo here, because it looks strange if the user uses a bright theme:

FWIW, that's the same theme I have. If you want to go with the static black background, go for it. If you update the PR I'll get it merged in.

Copy link
Contributor

@kenyonj kenyonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@kenyonj kenyonj added this pull request to the merge queue Jan 29, 2025
Merged via the queue into github:main with commit 0d0b633 Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants