fix: comment when an empty except occurs explaining why no action is taken #374
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This pull request includes updates to error handling in the
dependabot_file.py
andevergreen.py
files. The changes clarify that missing files are handled properly, are not errors, and we shouldn't create unnecessary logging unnecessary messages.Proposed Changes
Error handling improvements:
dependabot_file.py
: Updated thebuild_dependabot_file
function to handlegithub3.exceptions.NotFoundError
by continuing to the next file when a required file is missing, avoiding error raising or logging. This change is repeated in three different parts of the function. [1] [2] [3]evergreen.py
: Updated thecheck_existing_config
function to handlegithub3.exceptions.NotFoundError
similarly, ensuring that missing files are treated as non-critical and returningNone
instead of raising errors.Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducing@jeffrey-luszcz
Reviewer
fix
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking
This pull request introduces consistent handling for cases where a required file is not found in the repository. Instead of raising errors or logging, the code now explicitly continues to the next file, ensuring smoother execution in scenarios where certain files are optional.