Skip to content

Gmail's signature is not being detected #46

Description

@sashkab

When you parse emails, you detect signature by -- (dash-dash-space). But, Gmail for some odd reason, adds asterisks before and after signature delimiter, you should, probably, support this as well. In raw email it looks like this: *-- *.

Activity

  1. crimsonvspurple commented on Apr 6, 2017

    @crimsonvspurple

    Any love for this?

  2. peter-evans commented on Feb 11, 2025

    @peter-evans
    Member

    👋 @sashkab @crimsonvspurple

    I realise this is a very old issue, but if this is still affecting folks I would like to hear more detail because I've been unable to reproduce this. As far as I can tell, Gmail does use the standard signature delimiter, -- \n.

  3. sashkab commented on Feb 11, 2025

    @sashkab
    Author

    I've reported this almost ten years ago, I no longer have access to the systems I used to run this on, and email accounts, so I cannot reproduce this problem.

    Looks like gmail doesn't add -- automatically prior to signature, I have to add, and if I do, and mark text as bold, I will end up with *-- * instead.

    Image

    Unable to verify with the original message, as I no longer have access to that email account. Well, it was almost ten years ago :)

  4. peter-evans commented on Feb 11, 2025

    @peter-evans
    Member

    I appreciate it was a long time ago! Thank you for replying.

    Looks like gmail doesn't add -- automatically prior to signature, I have to add, and if I do, and mark text as bold, I will end up with *-- * instead.

    When you say that you mark the text as bold, are you selecting the -- , too? Or just the text underneath the delimiter?

    I just tried it by only marking the text under the delimiter as bold, and it correctly renders the raw email when sent.

    --
    *my sig*
    

    If you are selecting the delimiter, too, then that is the cause and there is not much that can be done about that. The delimiter must be -- \n to conform to the standard used by all mail client/servers.

  5. sashkab commented on Feb 12, 2025

    @sashkab
    Author

    Obviously, in this case I'm selecting -- as bold to demonstrate the issue right now. I don't think I selected it in the past, but who knows what was happening. I'm surprised, Google doesn't automatically adds -- prior to signature right now, perhaps in the past they did.

    My point is, no matter how smart the program is, there are always users, who manage to break things. While I don't think adding *-- * delimiter is correct thing to do, it might be a way to kill a class of failures of the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions