Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that pull requests cannot use issue forms #8702

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

Calinou
Copy link
Contributor

@Calinou Calinou commented Aug 1, 2021

Why:

Closes #8701

What's being changed:

Add a mention that pull requests cannot use issue forms, but only traditional pull request templates. (Correct me if I'm wrong 🙂)

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Aug 1, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 1, 2021
@ajs256
Copy link
Contributor

ajs256 commented Aug 1, 2021

I would put it above the "This example..." paragraph because it looks a little weird as it is:
image
Also, the note should be in a callout box:

{% note %}
**Note:** Take notes!
{% endnote %}

Maybe also link to the article about PR templates (/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository). Not sure if that's necessary though.

@Calinou Calinou dismissed a stale review via df88035 August 1, 2021 20:31
@ramyaparimi
Copy link
Contributor

@Calinou Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 2, 2021
@ethanpalm ethanpalm self-assigned this Aug 3, 2021
ethanpalm
ethanpalm previously approved these changes Aug 3, 2021
Copy link
Contributor

@ethanpalm ethanpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 @Calinou, thanks for creating this PR! I think this information can definitely help people who might try to use issue forms with pull requests. I've made just a few minor changes to align the content with our style guide. I'm going to update the branch and will get this merged as soon as all the checks are passing.

Thanks for contributing to the GitHub docs! ⚡

Comment on lines +150 to +152
- OS:
- Node:
- npm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the spacing here 😁

@ethanpalm ethanpalm enabled auto-merge August 3, 2021 16:45
@ethanpalm ethanpalm merged commit 1a85ac1 into github:main Aug 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue forms page should mention whether pull requests can use the new issue form functionality
4 participants