Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Typo roundup with cSpell #733

Merged
merged 26 commits into from
Nov 4, 2020
Merged

chore: Typo roundup with cSpell #733

merged 26 commits into from
Nov 4, 2020

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Oct 23, 2020 •
edited
Loading

Why:

Was building out a cSpell dictionary for an eventual CI. The WIP config is over here https://gist.github.com/nschonni/d8655aeb3f5479e79ca29f37b4c658f5, but I figured I'd PR the more straight-forward issues it found

What's being changed:

  • Typos across various content folder documents
  • Typos across various GraphQL data elements. This might actually be product bugs being generated from code comments. Each one is separated by commit, so they can be rebased if needed

Check off the following:

@nschonni nschonni requested a review from a team as a code owner October 23, 2020 02:22
heiskr
heiskr approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Fantastic pull request. aloglia has bugged me more than once 😂

nschonni
nschonni commented Oct 26, 2020
View reviewed changes
data/graphql/2.17/schema.docs-enterprise.graphql Outdated
@@ -2416,7 +2416,7 @@ type Commit implements GitObject & Node & Subscribable & UniformResourceLocatabl
committedDate: DateTime!

"""
Check if commited via GitHub web UI.
Check if committed via GitHub web UI.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a comment here, that these may be generated bugs from the product itself that need to be rebased out of this PR and addressed upstream

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, yeah, let me triage this for the ecosystem team so they can check out whether all of these can be merged 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I think these were in the JSON files too, but I didn't touch those

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 27, 2020
@janiceilene janiceilene added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 27, 2020
runleonarun
runleonarun suggested changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @nschonni Thanks for all of these awesome typo catches! Some of these files are automatically generated and some I just think we should leave because they are comments in scripts that would require an engineering review. Once you remove changes from these directories, this should be good to go:
tests/
scripts/
lib/
data/graphql/
data/glossaries/

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2020

@runleonarun I'll see if I can figure out how to filter-branch properly and move those to a separate PR

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2020

🎉 Fantastic pull request. aloglia has bugged me more than once 😂

@heiskr I pulled that change out for the content folks, but I'll resubmit it after this lands. Feel free to copy/submit the fix ahead of that though 😉

@nschonni
Copy link
Contributor Author

nschonni commented Nov 4, 2020

@runleonarun I rebased and threw on an extra commit because the heroku deploy stalled on the previous commit

runleonarun
runleonarun approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for removing those extra changes. 🙇

@runleonarun runleonarun merged commit 9bbec02 into github:main Nov 4, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni nschonni deleted the cspell branch November 4, 2020 20:19
This was referenced Nov 4, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request May 24, 2021
Merged
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@jacobprall
add 404 fixes (github#733)
027911b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiceilene janiceilene janiceilene left review comments

@runleonarun runleonarun runleonarun approved these changes

@heiskr heiskr heiskr approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nschonni @heiskr @runleonarun @janiceilene