Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(content-style-guide): add guidance on list delimiters #6010

Merged
merged 2 commits into from
May 4, 2021

Conversation

jai
Copy link
Contributor

@jai jai commented May 4, 2021

Signed-off-by: Jai Govindani jai@honestbank.com

Why:

Closes #6009

What's being changed:

Adds guidance on delimiters to be used in key/value-type lists. Proposes a colon as the standard.

https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#release
CleanShot 2021-05-02 at 12 24 45

Check off the following:

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (eg. a "before and after video")

Signed-off-by: Jai Govindani <jai@honestbank.com>
@jai jai requested a review from a team as a code owner May 4, 2021 04:45
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 4, 2021
@janiceilene janiceilene added contributing docs Content related to our contributing docs waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 4, 2021
@janiceilene
Copy link
Contributor

Thanks so much for opening an issue and an accompanying PR @jai! I've triaged this for review ✨

Copy link
Member

@emilyistoofunky emilyistoofunky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for spotting and fixing this @jai! ✨

@emilyistoofunky emilyistoofunky enabled auto-merge May 4, 2021 20:52
@emilyistoofunky emilyistoofunky merged commit d4cf221 into github:main May 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@redowll

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributing docs Content related to our contributing docs waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] add style guidance on delimiters used in lists
4 participants