Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghe-webhook-logs -v options example #5746

Merged
merged 3 commits into from
May 11, 2021

Conversation

kyanny
Copy link
Member

@kyanny kyanny commented Apr 27, 2021

From GHES 3.0, ghe-webhook-logs command does not have -v option.

Why:

Closes [issue link]

What's being changed:

Check off the following:

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (eg. a "before and after video")

From GHES 3.0, ghe-webhook-logs command does not have -v option.
@welcome
Copy link

welcome bot commented Apr 27, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 27, 2021
@janiceilene janiceilene added GHE waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 28, 2021
@janiceilene
Copy link
Contributor

@kyanny Thanks so much for opening a PR! I'll get this triaged for review ⚡

Next time, could you please fill out the Why and What's being changed in the pull request template? If you have any additional questions or want to chat, feel free to DM me 💛

@lucascosti lucascosti self-assigned this May 11, 2021
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps, @kyanny! I'll get this merged 🚢

@lucascosti lucascosti merged commit 4bdfc74 into github:main May 11, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants