-
Notifications
You must be signed in to change notification settings - Fork 61.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repo sync #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Melanie Yarbrough <11952755+myarb@users.noreply.github.com>
* Changes to devcontainer for codespaces * Still run `npm start` Co-authored-by: James M. Greene <JamesMGreene@github.com>
* Add middleware to timeout requests after a period * Add halt-on-dropped-connection middleware to stop the middleware processing stack if the connection was already dropped * Add a few strategic bail-out spots for dropped connections during the render-page middleware * Handle 404s and HEAD requests earlier in the page rendering flow * Add a few more strategic bail-out spots for dropped connections during the render-page middleware * Add middleware to notice aborted requests * Add a check for aborted requests into the isConnectionDropped logic * Reformat comment for consistency * Handle aborted requests correctly in the error handler * Explicit returns for consistency
* Do not load the timeout middleware during testing * Run the link-check-server in testing mode to avoid loading the timeout middleware * Revert the change to 'package.json' * Also consider GITHUB_ACTIONS to be a testing environment to support the link checkers
* Create a readFileAsync wrapper module * Use the readFileAsync wrapper module instead of fs.promises.readFile * Fix require path in test
…" or "good first issue" labels are added (#18047)
* Create production-config-change.md * Update production-config-change.md * Update production-config-change.md
Update EOL date for 2.20
* Add dependency graph 3-0 release notes * Clarify combo of dg issue and logging duplication * Update data/release-notes/3-0/0.yml * Update data/release-notes/3-0/1.yml Co-authored-by: Meg Bird <megbird@github.com> Co-authored-by: Sarah Schneider <sarahs@users.noreply.github.com>
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
milkly1235
reviewed
Apr 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Milk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automated-reposync-pr
Auto label for repo sync
triage
Do not begin working on this issue until triaged by the team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to sync changes between the public and private repos.
🤖 This pull request should be merged (not squashed) to preserve continuity across repos, so please let a bot do the merging!