Skip to content

Docker container actions and service containers only work on 'ubuntu-latest' #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Docker container actions and service containers only work on 'ubuntu-latest' #435

merged 3 commits into from
Oct 14, 2020

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Oct 12, 2020

replaced "ubuntu-latest image" with "ubuntu images" in the phrase

Note: If your workflows use Docker container actions or service containers, then you must use a Linux runner:

If you are using GitHub-hosted runners, you must use the ubuntu-latest runner.

See https://docs.github.com/en/free-pro-team@latest/actions/guides/about-service-containers#about-service-containers
Pay attention the is a reused data and blue block is to be changed across the whole documentation set.

The related issue: actions/runner-images#1624

Check off the following:

@AlenaSviridenko
Copy link
Contributor

LGTM

some context: Docker-Moby recently added support of Ubuntu-20.04 so now it is correct to say that Docker container actions or service containers can be used on all Ubuntu images.

@janiceilene
Copy link
Contributor

Thanks for opening a PR @dsame! I'll get this triaged for review ✨

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 12, 2020
@github github deleted a comment Oct 14, 2020
@github github deleted a comment Oct 14, 2020
@lucascosti lucascosti self-assigned this Oct 14, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR, @dsame! 🙇‍♂️

I might a slight change, and when the tests pass, I'll merge this in. 🚀

@lucascosti lucascosti merged commit 20fa34e into github:main Oct 14, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants