-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Add missing 'skipped' option to needs
#411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Thanks for opening a PR @Aebrathia! I'll get this triaged for review ✨ |
content/actions/reference/context-and-expression-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aebrathia Thanks a lot for this PR!
It took me a little while to figure out if it was even possible for a job that needs
a skipped job to actually run in order to see the context. but I did eventually get a workflow run that resulted in the output (using if: ${{ always() }}
😁) :
I'll get this PR merged in 🚀
@lucascosti thanks for your review, glad to know about Oxford commas. The issue you faced is a bit tricky and needs a bit doc digging. Default name: Deploy
jobs:
update:
if: # should update deployment configuration
steps:
- run: # update project
deploy:
needs: update
if: ${{ success() || needs.update.result == 'skipped' }} # Deploy even if no update (manual redeploy…)
steps:
- run: # deploy |
@Aebrathia If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
Ah, of course! Yes, I forgot about situation where |
Resolve site-bug [Issue with the page: /timescaledb/latest/quick-start/python/](timescale/docs#410)
Why:
I found out that the
needs.<job id>.result
context in Github Actions has an undocumented optionskipped
when the job dependency is skipped.What's being changed:
I added 'skipped' to the list of possible values.
Check off the following: