Skip to content

Add ChromeOS support in defaultPlatform frontmatter #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2021
Merged

Add ChromeOS support in defaultPlatform frontmatter #4102

merged 5 commits into from
Mar 17, 2021

Conversation

sirocyl
Copy link
Contributor

@sirocyl sirocyl commented Feb 28, 2021

Adds CrOS to defaultPlatform frontmatter, as a variant of Linux.

Why:

As noted in #4101, ChromeOS is not identified in pages which have multiple platform-specific parts.

What's being changed:

This change:

Check off the following:

Adds CrOS to defaultPlatform frontmatter, as Linux.
@sirocyl sirocyl requested a review from a team as a code owner February 28, 2021 07:03
@welcome
Copy link

welcome bot commented Feb 28, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@sirocyl Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added the engineering Will involve Docs Engineering label Mar 1, 2021
heiskr
heiskr previously approved these changes Mar 2, 2021
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 💃🏼

@heiskr
Copy link
Contributor

heiskr commented Mar 2, 2021

Oh, I think we'll need to update our event schema too; so that analytics events coming from ChromeOS pass the validation.

https://github.com/sirocyl/docs/blob/main/lib/schema-event.js#L76

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2021

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 9, 2021
@github-actions github-actions bot closed this Mar 13, 2021
@janiceilene
Copy link
Contributor

I don't think this one's stale! Reopening.

@janiceilene janiceilene reopened this Mar 16, 2021
@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review and removed stale There is no recent activity on this issue or pull request labels Mar 16, 2021
@sirocyl
Copy link
Contributor Author

sirocyl commented Mar 17, 2021

Just checking in - is there anything I need to do here, or are we just waiting to move through the pipeline?

@heiskr heiskr enabled auto-merge March 17, 2021 15:49
@heiskr heiskr disabled auto-merge March 17, 2021 15:50
@heiskr heiskr added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 17, 2021
@heiskr heiskr enabled auto-merge (squash) March 17, 2021 16:01
@heiskr heiskr merged commit abee1fc into github:main Mar 17, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Will involve Docs Engineering ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants