-
Notifications
You must be signed in to change notification settings - Fork 62.2k
[SEO] Redirect "Contact GitHub" footer link to Support site #4034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
translations/**
lib/rest/static/**
.github/workflows/**
.github/CODEOWNERS
translations/**
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>
. Once you get those files reverted, we can continue with the review process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for the PR, as the bot mentioned earlier the lib/redirects/*
can not be modified by any PR, so AFAIK sadly no one can accept this change to the code base. Unless the core team change this by themselves.
Thanks for opening a PR @skullface! This was discussed in Slack and can be merged in once the engineering team takes a look and gives approval 💖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Seems fine to me.
manually checked and overridden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
translations/**
lib/rest/static/**
.github/workflows/**
.github/CODEOWNERS
translations/**
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>
. Once you get those files reverted, we can continue with the review process.
This PR updates the redirect in place for "Contact GitHub" to minimize end-user redirects to have a positive impact on SEO.
Why:
https://github.com/github/SEO/issues/64
What's being changed:
https://support.github.com/contact
https://support.github.com
Check off the following: