-
Notifications
You must be signed in to change notification settings - Fork 61.9k
Correct duplicate branch-paths-filter.md paragraph #38445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
@norwd Looking at this more closely, isn't the duplicate note under "Running your workflow only when a push affects specific files"? The tags section is the one above. I'm going to check in with our SMEs about the necessity for having a note there at all, just to make sure it's needed and to keep this from getting held up more, but I thought I would point that out in case they agree that the note in that section needs to be included and updated. 💛 |
@norwd Okay, word from the SMEs is: only one note is necessary. Simplest fix would be to delete the second one. If, however, you would rather create an example with tag, path, and branch, update the reusable, and delete the first note instead, that was also a solution they proposed as acceptable. |
Seems, fair enough, I'll make that update now 👍 |
Perfect! I'll get this added to the merge queue once checks are passing. |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #38444
What's being changed (if available, include any code snippets, screenshots, or gifs):
I've reworded the second of two duplicate paragraphs to match the surrounding context. Namely, instead of saying specifying both
branches: [...]
andpaths: [...]
means both conditions must be satisfied twice, the second time it talks abouttags: [...]
instead (since it's under theRunning your workflow only when a push of specific tags occurs
heading).Check off the following: