Skip to content

Repo sync #38088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,14 @@ Ensure that you set the value for `Audience` on your IdP to the `EntityId` for {

{% data reusables.saml.current-time-earlier-than-notbefore-condition %}

{% ifversion ghes > 3.16 %}

## Error: "failure - Updated SAML validation returned an invalid result"

This error can occur in version 3.17.0 or later of {% data variables.location.product_location %}. It indicates that {% data variables.product.github %} is unable to properly process the SAML response it received from the identity provider. Please open a {% data variables.product.github %} support ticket so that the {% data variables.product.github %} Support and Engineering teams can investigate and address the issue.

{% endif %}

{% ifversion ghec %}
{% data reusables.saml.authentication-loop %}
{% endif %}
2 changes: 1 addition & 1 deletion src/events/components/experiments/experiments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const EXPERIMENTS = {
ai_search_experiment: {
key: 'ai_search_experiment',
isActive: true, // Set to false when the experiment is over
percentOfUsersToGetExperiment: 0, // 10% of users will get the experiment
percentOfUsersToGetExperiment: 1, // 10% of users will get the experiment
includeVariationInContext: true, // All events will include the `experiment_variation` of the `ai_search_experiment`
limitToLanguages: ['en'], // Only users with the `en` language will be included in the experiment
alwaysShowForStaff: true, // When set to true, staff will always see the experiment (determined by the `staffonly` cookie)
Expand Down
13 changes: 13 additions & 0 deletions src/graphql/data/fpt/changelog.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
[
{
"schemaChanges": [
{
"title": "The GraphQL schema includes these changes:",
"changes": [
"<p>Type <code>BotOrUser</code> was added</p>"
]
}
],
"previewChanges": [],
"upcomingChanges": [],
"date": "2025-05-06"
},
{
"schemaChanges": [
{
Expand Down
5 changes: 5 additions & 0 deletions src/graphql/data/fpt/schema.docs.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -2413,6 +2413,11 @@ type Bot implements Actor & Node & UniformResourceLocatable {
url: URI!
}

"""
Used when either Bot or User are accepted.
"""
union BotOrUser = Bot | User

"""
Types which can be actors for `BranchActorAllowance` objects.
"""
Expand Down
19 changes: 19 additions & 0 deletions src/graphql/data/fpt/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -94718,6 +94718,25 @@
}
]
},
{
"name": "BotOrUser",
"kind": "unions",
"id": "botoruser",
"href": "/graphql/reference/unions#botoruser",
"description": "<p>Used when either Bot or User are accepted.</p>",
"possibleTypes": [
{
"name": "Bot",
"id": "bot",
"href": "/graphql/reference/objects#bot"
},
{
"name": "User",
"id": "user",
"href": "/graphql/reference/objects#user"
}
]
},
{
"name": "BranchActorAllowanceActor",
"kind": "unions",
Expand Down
5 changes: 5 additions & 0 deletions src/graphql/data/ghec/schema.docs.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -2413,6 +2413,11 @@ type Bot implements Actor & Node & UniformResourceLocatable {
url: URI!
}

"""
Used when either Bot or User are accepted.
"""
union BotOrUser = Bot | User

"""
Types which can be actors for `BranchActorAllowance` objects.
"""
Expand Down
19 changes: 19 additions & 0 deletions src/graphql/data/ghec/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -94718,6 +94718,25 @@
}
]
},
{
"name": "BotOrUser",
"kind": "unions",
"id": "botoruser",
"href": "/graphql/reference/unions#botoruser",
"description": "<p>Used when either Bot or User are accepted.</p>",
"possibleTypes": [
{
"name": "Bot",
"id": "bot",
"href": "/graphql/reference/objects#bot"
},
{
"name": "User",
"id": "user",
"href": "/graphql/reference/objects#user"
}
]
},
{
"name": "BranchActorAllowanceActor",
"kind": "unions",
Expand Down
4 changes: 2 additions & 2 deletions src/search/components/input/SearchOverlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -794,8 +794,8 @@ export function SearchOverlay({
// Hubbers users use an internal discussion for feedback
window.open('https://github.com/github/docs-team/discussions/5172', '_blank')
} else {
// TODO: On ship date set this value
// window.open('TODO', '_blank')
// public discussion for feedback
window.open('https://github.com/orgs/community/discussions/158488', '_blank')
}
}}
as="button"
Expand Down
Loading