Skip to content

use pull_request_target #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021
Merged

use pull_request_target #3783

merged 2 commits into from
Feb 18, 2021

Conversation

rachmari
Copy link
Contributor

@rachmari rachmari commented Feb 18, 2021

Why:

From:

In order to protect public repositories for malicious users we run all pull request workflows raised from repository forks with a read-only token and no access to secrets. This makes common workflows like labeling or commenting on pull requests very difficult.

We need workflows that run on forks to be able to read the FREEZE secret in the github/docs repo. This updates the workflow to use the pull_request_target event, which allows using the base repos secrets in a workflow.

Added workflow_dispatch for good measure. We can use this to run this workflow on a different branch to test it out.

@rachmari rachmari requested a review from a team as a code owner February 18, 2021 21:34
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
translations/**
lib/rest/static/**
.github/workflows/**
.github/CODEOWNERS
translations/**
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@rachmari rachmari merged commit 380142c into main Feb 18, 2021
@rachmari rachmari deleted the rachmari-patch-2 branch February 18, 2021 21:42
Dmarch28 pushed a commit to Dmarch28/docs that referenced this pull request Mar 4, 2021
Dmarch28 pushed a commit to Provider-of-Algorithms/docs that referenced this pull request Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants