Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy/pasta in label_short_desc #3769

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Feb 18, 2021

Why:

I'm working on adding label names to our GitHub events pipeline so that I can derive some metrics from label changes. Based on prior art in our repo I'm pulling payload examples from the docs to use as test fixture. This is where I ran across label_short_desc in the wild, and I was confused because it made me think maybe the labels payload is about the application of a label to an issue, when in fact of course it's about the label itself.

before

What's being changed:

The word "issue" is being changed to "label" (with subordinate emendation in preservation of articular agreement), fixing presumably a scribal error deriving from the derivation of label_short_desc from issue_short_desc without sufficient original modification of the original, herein forsooth forthwith corrected.

after

Check off the following:

@welcome
Copy link

welcome bot commented Feb 18, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@chadwhitacre Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team webhooks Content related to webhooks labels Feb 18, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 18, 2021
@ethanpalm
Copy link
Contributor

@chadwhitacre This looks great 👍 Thanks for catching that typo and opening a PR to fix it! I'll update the branch and get this merged posthaste once tests are passing. 🍏

@ethanpalm ethanpalm added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Feb 24, 2021
@ethanpalm ethanpalm self-assigned this Feb 25, 2021
@ethanpalm ethanpalm removed the ready to merge This pull request is ready to merge label Feb 25, 2021
@ethanpalm ethanpalm merged commit b606e67 into github:main Feb 25, 2021
@chadwhitacre chadwhitacre deleted the patch-1 branch March 15, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team webhooks Content related to webhooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants