Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Desktop] Stashing changes feature #3598

Merged
merged 14 commits into from
Mar 1, 2021
Merged

Conversation

ethanpalm
Copy link
Contributor

@ethanpalm ethanpalm commented Feb 10, 2021

Why:

Closes #1202

This PR creates a new article, "Stashing changes," to document a new feature and moves content about stashing changes from "Managing branches" to the new article.

What's being changed:

I used two reusables/two steps for the new procedure on stashing changes rather than one so that click-changed-files-header.md can be reused if the Discard All Changes feature is documented later.

Article in staging Source Changes
"Stashing changes" Source Create new article
index.md Source Update index
"Managing branches" Source Move content about restoring stashed changes to new article

Check off the following:

@ethanpalm ethanpalm changed the title Desktop stashing changes [GitHub Desktop] Stashing changes feature Feb 10, 2021
@ethanpalm ethanpalm marked this pull request as ready for review February 10, 2021 21:57
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have any questions!

Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. 👍

I've made a few small inline suggestions. Just a couple of other things:

A few of the images (particularly the Mac versions) result in the page being quite spacey. You could crop <OS>-changed-file-header.png and <OS>--stash-all-changes.png to lose the empty bottom part of the image. Also (although I'm nit-picking here) you could lose some of the white space at the bottom of <OS>-restore-stashed-changes-button.png and <OS>discard-stashed-changes-button.png, just to tighten up the page a little.

It looks like 3 of the reusables you've created are only used once. This works okay but I'd recommend only creating reusables when you're using them more than once. I'd suggest not creating reusables for possible future reuse.

The new page is looking looking really good. Nice work. 🎖️

@ethanpalm ethanpalm dismissed a stale review via 97d6de9 February 18, 2021 15:29
shati-patel
shati-patel previously approved these changes Feb 26, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks like a useful new article! ✨

One small suggestion, otherwise 👍🏽 (I'm happy to re-approve if the suggestion dismisses this review 😉)

data/reusables/desktop/click-discard.md Outdated Show resolved Hide resolved
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@ethanpalm ethanpalm merged commit 3e6f08f into main Mar 1, 2021
@ethanpalm ethanpalm deleted the desktop-stashing-changes branch March 1, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GitHub Desktop] Stashing changes feature
4 participants