-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GitHub Desktop] Stashing changes feature #3598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you have any questions!
content/desktop/contributing-and-collaborating-using-github-desktop/stashing-changes.md
Outdated
Show resolved
Hide resolved
content/desktop/contributing-and-collaborating-using-github-desktop/managing-branches.md
Show resolved
Hide resolved
content/desktop/contributing-and-collaborating-using-github-desktop/stashing-changes.md
Outdated
Show resolved
Hide resolved
content/desktop/contributing-and-collaborating-using-github-desktop/stashing-changes.md
Outdated
Show resolved
Hide resolved
content/desktop/contributing-and-collaborating-using-github-desktop/stashing-changes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. 👍
I've made a few small inline suggestions. Just a couple of other things:
A few of the images (particularly the Mac versions) result in the page being quite spacey. You could crop <OS>-changed-file-header.png
and <OS>--stash-all-changes.png
to lose the empty bottom part of the image. Also (although I'm nit-picking here) you could lose some of the white space at the bottom of <OS>-restore-stashed-changes-button.png
and <OS>discard-stashed-changes-button.png
, just to tighten up the page a little.
It looks like 3 of the reusables you've created are only used once. This works okay but I'd recommend only creating reusables when you're using them more than once. I'd suggest not creating reusables for possible future reuse.
The new page is looking looking really good. Nice work. 🎖️
content/desktop/contributing-and-collaborating-using-github-desktop/stashing-changes.md
Outdated
Show resolved
Hide resolved
content/desktop/contributing-and-collaborating-using-github-desktop/managing-branches.md
Outdated
Show resolved
Hide resolved
content/desktop/contributing-and-collaborating-using-github-desktop/stashing-changes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this looks like a useful new article! ✨
One small suggestion, otherwise 👍🏽 (I'm happy to re-approve if the suggestion dismisses this review 😉)
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Why:
Closes #1202
This PR creates a new article, "Stashing changes," to document a new feature and moves content about stashing changes from "Managing branches" to the new article.
What's being changed:
I used two reusables/two steps for the new procedure on stashing changes rather than one so that
click-changed-files-header.md
can be reused if the Discard All Changes feature is documented later.index.md
Check off the following: