-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent alerts by using the markdown notation #35216
Fix inconsistent alerts by using the markdown notation #35216
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:
You'll need to revert all of the files you changed that match that list using GitHub Desktop or The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
Is there a way to go around the following lint error?
|
@akordowski Thank you so much for the time and effort put into this PR! ✨ 🚀 We didn't expect a PR to change every inconsistency, and are greatly appreciative of the energy put into improve our docs 🙇
Unfortunately there isn't - would you be alright with breaking up your PR into multiple PRs smaller than the max files limit (300)? 💛 |
You're very welcome!
That was also my idea. Maybe a PR for each seaction? (Actions, Copilot, ...) That would propably also make it easier to review. What do you think? Should I also create an new issue for each PR or reference to the existing one? |
This sounds like an excellent plan! 💛
Feel free to just have each PR reference the existing issue! Thank you! |
@nguyenalex836 Ok, will do. Thank you! |
As this PR exceeds the linter limit of 300 files, this PR is splited into 4 new ones, see here. This PR will be closed. |
Why:
As described in the issue #35195 the display of alerts is inconsistent across the documentation. The following PR provides changes to all alerts according to the docs guidelines using the Markdown notation.
Closes: #35195
What's being changed (if available, include any code snippets, screenshots, or gifs):
All alerts for
note
,tip
,important
andwarning
have been changed and unified from the following notation to the Markdown notation according to the docs guidelines.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.