Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row to Styling text - Underline #35076

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

jhauga
Copy link
Contributor

@jhauga jhauga commented Oct 25, 2024

Why:

Underlining text is a common method of styling text.

Closes:

#35075

What's being changed (if available, include any code snippets, screenshots, or gifs):

A row is being added to styling text section of the page basic-writing-and-formatting-syntax.md. Below is the row being added to the table:

| Underline | <ins> </ins> | None | This is an <ins>underlined</ins> text | This is an underlined text |

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Add a row for in underlining text in the "Styling text" section. Using "ins" tags to underline text in markdown file.
Copy link

welcome bot commented Oct 25, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 25, 2024
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Oct 28, 2024
@nguyenalex836
Copy link
Contributor

@jhauga Thanks so much for opening a PR! I'll get this triaged for review ✨

rachaelrenk
rachaelrenk previously approved these changes Oct 28, 2024
Copy link
Contributor

@rachaelrenk rachaelrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jhauga 👋 thank you for adding this example! Also, I appreciate the clear PR description - it made it easy to understand the "what" and "why" of your changes. I tweaked the text of the rendered example for consistency, but otherwise this LGTM. We will get this merged next week after the Docs repo freeze ends. 🛸

…ting-and-formatting-on-github/basic-writing-and-formatting-syntax.md
@nguyenalex836 nguyenalex836 added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 28, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Nov 1, 2024
Merged via the queue into github:main with commit 43aeef8 Nov 1, 2024
44 checks passed
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jhauga jhauga deleted the underline-row-text-styling-row branch November 1, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing underline tag in "Styling text" section of basic-writing-and-formatting-syntax.md
3 participants