Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mention of live share in codespace docs #34391

Conversation

gagan-bhullar-tech
Copy link
Contributor

@gagan-bhullar-tech gagan-bhullar-tech commented Aug 23, 2024

Why:

Closes: #34390

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 23, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
codespaces/developing-in-a-codespace/index.md fpt
ghec
fpt
ghec
Removed: codespaces/developing-in-a-codespace/working-collaboratively-in-a-codespace.md n/a fpt
ghec
removed
codespaces/guides.md fpt
ghec
fpt
ghec
codespaces/overview.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@gagan-bhullar-tech
Copy link
Contributor Author

Can anyone please let me know how to setup redirects.

@nguyenalex836
Copy link
Contributor

@gagan-bhullar-tech Thank you for submitting this PR! ✨ I'm going to check with our engineering team to see how to resolve that failed test regarding the redirect 👍

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team Codespaces Content relating to GitHub Codespaces and removed triage Do not begin working on this issue until triaged by the team labels Aug 23, 2024
Saldivar003

This comment was marked as spam.

Saldivar003

This comment was marked as spam.

@nguyenalex836
Copy link
Contributor

Collaborating w/ team on the failed check

@gagan-bhullar-tech
Copy link
Contributor Author

@nguyenalex836 i am unable to login to the above link. Please let me know the outcome of discussion. Thanks.

@hubwriter
Copy link
Contributor

We may have to leave a very short article mentioning Live Share deprecation. Please hold off on this for now. I'm talking to the developer who worked on this.

Thanks

Copy link
Contributor

github-actions bot commented Sep 3, 2024

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Sep 3, 2024
@github-actions github-actions bot closed this Sep 3, 2024
@nguyenalex836
Copy link
Contributor

We may have to leave a very short article mentioning Live Share deprecation. Please hold off on this for now. I'm talking to the developer who worked on this.

Thanks

@hubwriter Hello! 👋 Do we have an update from the developer who worked on this originally? @CBID2 recently submitted a PR to address this as well, and so I've removed the help wanted label from the original issue for the time being

@hubwriter
Copy link
Contributor

Thanks @nguyenalex836 - by coincidence I finally heard back from the developer about this just last night. The changes to Live Share just affect the backend service being used. From the user point of view Live Share will still be available, so no changes are needed to the docs after all.

I'll close the new PR and the issue for this.

AhmedMostafaoo7

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mention of Live Share from the Codespaces docs
5 participants