Clarify concurrency cancel-in-progress behaviour #30647
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
bot
added
the
triage
rvesse
force-pushed
the
concurrency-cancellation-clarifications
branch
from
9b41d40 to
ab0beb4
Compare
|
@rvesse Thanks so much for opening a PR and linking to your issue! I'll get this triaged for review ✨ |
nguyenalex836
added
content
rvesse
force-pushed
the
concurrency-cancellation-clarifications
branch
2 times, most recently
from
05b6eb4 to
581b320
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
The section on GitHub Actions concurrency did not cover whether cancel-in-progress could use an expression and several discussions exists expressing confusion around this. This commit aims to clarify this part of the documentation and include an explicit example of using an expression for cancel-in-progress. It also adds clarifying language so that it is clear that even when cancel-in-progress is, or evaluates to, false, that there can still only be at most 1 running and 1 pending job in any given concurrency group.
rvesse
force-pushed
the
concurrency-cancellation-clarifications
branch
from
581b320 to
f6bd7d6
Compare
There was a problem hiding this comment.
Thank you for adding this content to our docs, @rvesse! I made a couple of style edits to match our content models and style guide. I will just apply those directly to your PR and get this merged! Thanks again for a great contribution. 💛
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The section on GitHub Actions concurrency did not cover whether
cancel-in-progresscould use an expression and several open discussions exists expressing confusion around this e.g.Closes: #30645
What's being changed (if available, include any code snippets, screenshots, or gifs):
This commit aims to clarify this part of the documentation and include an explicit example of using an expression for
cancel-in-progressIt also adds clarifying language so that it is clear that even when
cancel-in-progressis, or an expression that evaluates to,false, that there can still only be at most 1 running and 1 pending job in any given concurrency group.Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.For content changes, I have completed the self-review checklist.