add fragment identifiers to the glossary terms #29004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
bot
added
the
triage
steveward
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Thanks for the PR @Junaid-1993! Looks great to me, I'll get this merged.
steveward
added
content
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
steveward
added
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
I was reading Github glossaries and found that I few terms referencing other terms like "see this also" but they are not actually linked using fragment identifiers so I have added them.
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
I have changed only two lines in the
external.ymlfile in the data/glossaries/external.yml.Check off the following:
[✔] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
datadirectory.[✔] For content changes, I have completed the self-review checklist.