-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Capitalize the H in GitHub #2851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions.
lib/rest/static/decorated/api.github.com.json
lib/rest/static/dereferenced/api.github.com.deref.json
lib/rest/static/dereferenced/ghes-2.18.deref.json
lib/rest/static/dereferenced/ghes-2.19.deref.json
lib/rest/static/dereferenced/ghes-2.20.deref.json
lib/rest/static/dereferenced/ghes-2.21.deref.json
lib/rest/static/dereferenced/ghes-2.22.deref.json
lib/rest/static/dereferenced/github.ae.deref.json
lib/webhooks/static/dotcom/package.published.payload.json
You'll need to revert all of these ☝️ files using GitHub Desktop or git checkout origin/main <file name>
. Once you get those files reverted, we can continue with the review process.
It looks like you've modified the OpenAPI schema (lib/rest/static/**
). While we aren't accepting changes to the schema directly, you can open an issue for any updates to the REST API docs. Head on over to the github/rest-api-description
repository to open an issue. ⚡
@anywherepilot Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨ |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes and for your patience, @anywherepilot! 🙏🏻
I've reverted the changes to the two articles about Okta, as they refer to strings in a UI that we at GitHub can't fix where the text remains "Github" with a lower-case 'h'.
We have variables for "GitHub App" and "GitHub Apps". These variables would be a better replacement for these (literal) strings, and would help to avoid this problem in the future. I've demonstrated this in c2a05fe and replaced some literal uses of "OAuth App[s]", too.
I'd like to publish your improvements, so I'll leave the variable replacements for future work. It's more time-consuming than a find-and-replace job. If you're feeling motivated, though, we'd welcome another pull request 😄
Addressed in bbc3d4e.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
Because this is our brand name. I didn't change references to other people their projects if they spelled it with a lowercase h (mostly in the libraries.md file).
I didn't find any other forms of misspellings. It's possible there's a bunch of all lowercase "github" out there, since that's hard to search for with the URLs all over the place.
What's being changed:
Github -> GitHub.
Check off the following: