Skip to content

Conversation

@felicitymay
Copy link
Contributor

@felicitymay felicitymay commented Sep 11, 2023

Why:

Closes: #27902

What's being changed (if available, include any code snippets, screenshots, or gifs):

The description of the "alerts" syntax now mentions "blockquote" which should make it easier for users to find the information if they search for it after reading the discussion post that introduced the feature: https://github.com/orgs/community/discussions/16925.

Note, we won't be able to confirm the improvement in SEO until after this PR is merged, so the changes should be reviewed on their own merit.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@felicitymay felicitymay marked this pull request as ready for review September 11, 2023 10:21
@felicitymay felicitymay added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review core and removed triage Do not begin working on this issue until triaged by the team core labels Sep 11, 2023
subatoi
subatoi previously approved these changes Sep 11, 2023
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: just a minor thought

…ting-and-formatting-on-github/basic-writing-and-formatting-syntax.md

Co-authored-by: Ben Ahmady <32935794+subatoi@users.noreply.github.com>
@felicitymay
Copy link
Contributor Author

Thanks for the review suggestions @subatoi and the 👍🏻 @jsoref

I think we can merge this, but first I'll need another approval from you Ben, now that I've committed your suggested changes.

Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@felicitymay felicitymay added this pull request to the merge queue Sep 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 12, 2023
@felicitymay felicitymay added this pull request to the merge queue Sep 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 12, 2023
@felicitymay felicitymay added the ready to merge This pull request is ready to merge label Sep 12, 2023
@felicitymay felicitymay added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 893e57a Sep 12, 2023
@felicitymay felicitymay deleted the felicitymay-add-blockquote branch September 12, 2023 17:29
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add blockquote to Basic writing and formatting syntax

3 participants